Remove unused variables #561

Merged
merged 1 commit into from Apr 9, 2014

Conversation

3 participants
@tgriesser
Contributor

tgriesser commented Apr 9, 2014

Saw there were a few unused require's when looking at utils.js and decided to do a quick pass and take out anything obviously unused (not unused arguments, except where they're incorrect).

@brianc

This comment has been minimized.

Show comment
Hide comment
@brianc

brianc Apr 9, 2014

Owner

Ooff there's a merge conflict somewhere. 😦 You want me to resolve that? I definitely appreciate the fine toothed comb on some of the older code here 🙈

Owner

brianc commented Apr 9, 2014

Ooff there's a merge conflict somewhere. 😦 You want me to resolve that? I definitely appreciate the fine toothed comb on some of the older code here 🙈

@tgriesser

This comment has been minimized.

Show comment
Hide comment
@tgriesser

tgriesser Apr 9, 2014

Contributor

Sure thing, should be okay now!

Contributor

tgriesser commented Apr 9, 2014

Sure thing, should be okay now!

@brianc

This comment has been minimized.

Show comment
Hide comment
@brianc

brianc Apr 9, 2014

Owner

Hollar! Thank you! 👍 💃

Owner

brianc commented Apr 9, 2014

Hollar! Thank you! 👍 💃

brianc added a commit that referenced this pull request Apr 9, 2014

@brianc brianc merged commit 492f1eb into brianc:master Apr 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@tgriesser tgriesser deleted the tgriesser:unused-vars branch Apr 9, 2014

@booo

This comment has been minimized.

Show comment
Hide comment
@booo

booo Apr 9, 2014

Collaborator

Can we catch this with jshint? Should be possible as far as I can see from the documentation: http://www.jshint.com/docs/

Collaborator

booo commented on cd05033 Apr 9, 2014

Can we catch this with jshint? Should be possible as far as I can see from the documentation: http://www.jshint.com/docs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment