Fix memory leak with domains #567

Merged
merged 1 commit into from Apr 12, 2014

3 participants

@brianc
Owner

This fixes an issue where memory was slowly leaked if you were using domains with node-postgres. I don't understand the underlying reason with the memory leak - everything I did looked like it lined up with the node.js documentation on domains. None the less I confirmed (and was bitten in production by) a memory leak here and this code resolves it while maintaining functionality for the majority of the use cases.

With this release I am going to unpublish the buggy releases.

@brianc brianc merged commit 88ff470 into master Apr 12, 2014

1 check passed

Details continuous-integration/travis-ci The Travis CI build passed
@dstokes

you figure out how this was leaking?

@tgriesser

Ping @xaka to take a look at this in reference to the PR here: bookshelf/generic-pool-redux#1

@brianc brianc deleted the fix-memory-leak branch Nov 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment