Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Remove unused parameter 'name' from DataRowMessage. #573

Merged
merged 1 commit into from

2 participants

@karvaporo

This hasn't been a problem (at least not yet) because the length and fieldCount properties aren't used anywhere. Nevertheless, I reckoned this is the intended form of DataRowMessage since there is an invocation of "new DataRowMessage(length, fieldCount)" down the line.

@brianc
Owner

Nice catch! :sunrise:

@brianc brianc merged commit 65d177e into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 19, 2014
  1. Remove unused parameter 'name' from DataRowMessage.

    Matti Virolainen authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/connection.js
View
2  lib/connection.js
@@ -478,7 +478,7 @@ Connection.prototype.parseField = function(buffer) {
};
var DATA_ROW = 'dataRow';
-var DataRowMessage = function(name, length, fieldCount) {
+var DataRowMessage = function(length, fieldCount) {
this.name = DATA_ROW;
this.length = length;
this.fieldCount = fieldCount;
Something went wrong with that request. Please try again.