avoid eval if the row is returned as an array #594

Merged
merged 1 commit into from May 22, 2014

Conversation

2 participants
@lukemurray
Contributor

lukemurray commented May 20, 2014

Fix for issue 593

@lukemurray

This comment has been minimized.

Show comment
Hide comment
@lukemurray

lukemurray May 20, 2014

Contributor

Hmm it looks like npm install failed on the node 0.8 build? Did I read that correctly?

Contributor

lukemurray commented May 20, 2014

Hmm it looks like npm install failed on the node 0.8 build? Did I read that correctly?

@brianc

This comment has been minimized.

Show comment
Hide comment
@brianc

brianc May 22, 2014

Owner

kicking the build off again - probably a temporary npm issue

Owner

brianc commented May 22, 2014

kicking the build off again - probably a temporary npm issue

@brianc

This comment has been minimized.

Show comment
Hide comment
@brianc

brianc May 22, 2014

Owner

Thanks for the PR! Good catch too 👏

I'll close the issue related to this & just track this from here for now. I'll try to get a new patch version out today.

Owner

brianc commented May 22, 2014

Thanks for the PR! Good catch too 👏

I'll close the issue related to this & just track this from here for now. I'll try to get a new patch version out today.

@brianc

This comment has been minimized.

Show comment
Hide comment
@brianc

brianc May 22, 2014

Owner

just gonna merge it. dumb npm bug preventing install on v0.8.x in travis

Owner

brianc commented May 22, 2014

just gonna merge it. dumb npm bug preventing install on v0.8.x in travis

brianc added a commit that referenced this pull request May 22, 2014

Merge pull request #594 from lukemurray/master
avoid eval if the row is returned as an array

@brianc brianc merged commit f8df873 into brianc:master May 22, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details
@lukemurray

This comment has been minimized.

Show comment
Hide comment
@lukemurray

lukemurray May 22, 2014

Contributor

Awesome. Thanks

Contributor

lukemurray commented May 22, 2014

Awesome. Thanks

@brianc

This comment has been minimized.

Show comment
Hide comment
@brianc

brianc May 23, 2014

Owner

Thank you!

Owner

brianc commented May 23, 2014

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment