Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change urls in docs to use example.net/.com #50

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@steveax
Copy link
Contributor

steveax commented Apr 9, 2019

Prior to this commit, the docs and vmfloaty.yml.example file used
a variety of live domains (mycompany.net, alternate.net). This commit
changes those to example.net and example.com which are IANA-managed
Reserved Domains. This will reduce the chance that any credentials
could be harvested if a user executes the example commands without
changing the domains.

Status

[Ready for Merge | In Progress | ???]

Description

FIXME

Related Issues

Todos

  • Tests
  • Documentation

Reviewers

@demophoon
@briancain

change urls in docs to use example.net/.com
Prior to this commit, the docs and vmfloaty.yml.example file used
a variety of live domains (mycompany.net, alternate.net). This commit
changes those to example.net and example.com which are IANA-managed
Reserved Domains. This will reduce the chance that any credentials
could be harvested if a user executes the example commands without
changing the domains.

@demophoon demophoon merged commit 697cc87 into briancain:master Apr 10, 2019

@demophoon

This comment has been minimized.

Copy link
Collaborator

demophoon commented Apr 10, 2019

Thanks @steveax for the updates! Hopefully not too much traffic was sent to those live domains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.