LPS-132087 Migrate selection modals in commerce-bom-admin-web #102005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
liferay-continuous-integration
deleted the
ci-forward-LPS-132087-pr-1185-sender-jonmak08-ts-1621415584466
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-commerce#1185 (Took 1
ci:forwardattempt in 1 minute)Console
@jonmak08
@liferay-commerce
Original pull request comment:
Hey @liferay-commerce,
Attached is an update for http://issues.liferay.com/browse/LPS-132087.
I was not able to figure out how to test these changes since I only go the modal to appear, but could not add any data/items to the search container to test if the selection actually works.
Test Plan:
+and Add Folder+to open the modalPlease let me know if you have any questions. Thanks!
Previous
ci:test:relevantbuild was successfully reevaluated against more recent upstream results.✔️ ci:test:stable - 9 out of 9 jobs passed
✔️ ci:test:relevant - 22 out of 24 jobs passed in 2 hours 7 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 7c184651e2050668d11ebd3a3012cff702b47d25
Upstream Comparison:
Branch GIT ID: b5017f0d112594164c8de23386975cc867d4c1b2
Jenkins Build URL: Acceptance Upstream DXP (master) #1868
ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 24 jobs PASSED
3 Failed Jobs:
test-portal-acceptance-pullrequest(master)test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/121 Successful Jobs:
For more details click here.
This pull contains no unique failures.
Failures in common with acceptance upstream results at b5017f0:
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
49 Tests Passed.
2 Tests Failed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1
Job Results:
30 Tests Passed.
2 Tests Failed.
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: e900eb0c19937e5c32e2aa84b5208d1c7ef6570d
Sender Branch:
Branch Name: LPS-132087
1 out of 1jobs PASSEDBranch GIT ID: 45bdd49a1c023b159519dbee35c8072a8d8a91c8
1 Successful Jobs:
For more details click here.