Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-131054 Fix failing tests #108035

Closed
wants to merge 4 commits into from

Conversation

austinchiang
Copy link

@austinchiang austinchiang commented Sep 30, 2021

Windows processes will block as soon as their output buffer is
full. We need to empty it every time we reach the timeout without the
process exiting.
@liferay-continuous-integration
Copy link
Collaborator

Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

Closing pull request because all liferay-portal pullrequests sent to Brian Chan must be sent by using ci:forward on a pull request that was sent to someone else.

@austinchiang
Copy link
Author

ci:reopen

@austinchiang
Copy link
Author

@brianchandotcom this fixes a blocker for the release. There was a commerce test failure blocking this pull from being forwarded but it's unrelated so I am sending this directly to you. Thanks!

@adolfopa

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 48d85e4...6db2c45

@brianchandotcom
Copy link
Owner

@adolfopa see 6db2c45

1.) Do we need to delete the temp file?

File destinationFile = FileUtil.createTempFile(format);

2.)

Can you sort the usage?

"ffmpeg", "-y", "-i", file.getAbsolutePath(), "-b:a",
				String.valueOf(
					_getProperty(
						audioProperties,
						PropsKeys.DL_FILE_ENTRY_PREVIEW_AUDIO_BIT_RATE, format,
						_AUDIO_BIT_RATE_DEFAULT)),
				"-ar",
				String.valueOf(
					_getProperty(
						audioProperties,
						PropsKeys.DL_FILE_ENTRY_PREVIEW_AUDIO_SAMPLE_RATE,
						format, _AUDIO_SAMPLE_RATE_DEFAULT)),
				destinationFile.getAbsolutePath()));

by flag (alphabetically)

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants