Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-64216 Task cache #39234

Closed
wants to merge 2 commits into from
Closed

Conversation

@brunobasto
Copy link

brunobasto commented Apr 28, 2016

No description provided.

@brianchandotcom brianchandotcom force-pushed the brianchandotcom:master branch from 31f8744 to 0c638da Apr 28, 2016

String loginRedirectParameter = loginPortletNamespace + "redirect";

return GetterUtil.getString(

This comment has been minimized.

Copy link
@brunobasto

brunobasto Apr 28, 2016

Author

@brianchandotcom To use ParamUtil here I would have to add a dependency to "provided group: "javax.portlet", name: "portlet-api", version: "2.0""

If you want I can add it. I didn't think it was worth adding a dependency though.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Apr 29, 2016

Some tests FAILED!

Build Time: 1 hour 32 minutes 37 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 31f8744e728bf9fcca394a218b241acad9764cff

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    61 Jobs Passed.
    5 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/5
    Job Results:

    31 Tests Passed.
    1 Test Failed.

    1. PoshiRunner.test[CPSitepages#AddSitePublicChildPage] - CPSitememberships#RemoveMember - CPSitepages#AddSitePublicChildPage - CPSitepages#AddSitePublicPage - Poshi Summary - Console Output
  3. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql56-jdk7
    Job Results:

    4635 Tests Passed.
    1 Test Failed.

    1. PortalLogAssertorTest.testScanXMLLog
  4. test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk7
    Job Results:

    1262 Tests Passed.
    1 Test Failed.

    1. SourceFormatterTest.testSourceFormatter
  5. test-portal-acceptance-pullrequest-batch(master)/unit-jdk7
    Job Results:

    2285 Tests Passed.
    1 Test Failed.

    1. InitUtilTest.testBaseSeleniumTestCaseSpringConfigs
For upstream results, click here.
@brianchandotcom brianchandotcom mentioned this pull request Apr 29, 2016
@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Apr 29, 2016

Merged. Thank you.
View total diff: ed3751c...f7b2ab1

@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Apr 29, 2016

@brunobasto thx for the mention. I went ahead and added ParamUtil because it's a provided dependency anyways. Doesn't cost us anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.