Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-69392 #45112

Closed
wants to merge 1 commit into from
Closed

LPS-69392 #45112

wants to merge 1 commit into from

Conversation

jorgediaz-lr
Copy link

@jorgediaz-lr jorgediaz-lr commented Nov 29, 2016 •
edited

I sent this pull to @mhan810 (see mhan810#1280) and he said I can forward it to you mhan810#1280 (comment)

https://issues.liferay.com/browse/LPS-69392

In case of activating debug traces for index buffer (com.liferay.portal.search.internal.buffer) we are having a lot of exceptions.
That debug traces were added in LPS-67703 but they are not necessary because it is a controlled error:

  1. In order to avoid duplicated reindex operations for ResourcedModel, in LPS-67703 we search the object using classPK and call resourcedModel.getResourcePrimKey()
  2. But sometimes for JournalArticle, classPK parameter is already the resourcePrimKey, so we get a NoSuchModelException but it is ok, we can ignore it because JournalArticleIndexer handles both id fields

So I am removing the exception but maintaining the log.debug, see: mhan810@3753552

@jorgediaz-lr
LPS-69392 Do not write the full exception to log because NoSuchModelE…
bab0470 
…xception is a controlled error:

    -Problem: In case of reindexation of a ResourcedModel, classPK can be a primaryKey or a resourcePrimaryKey. In that case, during indexation we want to use only resourcePrimaryKey to avoid duplicated reindexes
    -Solution: We try searching object by classPK, in case of retrieving it, we call resourcedModel.getResourcePrimKey() . In case of error, we can ignore the exception because classPK is already a resourcePrimaryKey
@liferay-continuous-integration
Copy link
Collaborator

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

Job Results:

2456 Tests Passed.
1 Test Failed.

  1. ReleaseVersionsTest.testReleaseVersions

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED.

Build Time: 1 hour 15 minutes 42 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 5be4ea8c6e7fe0210f95b51d6572cd51e19764d1

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    89 Jobs Passed.
    2 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/unit-jdk8
    Job Results:

    2456 Tests Passed.
    1 Test Failed.

    1. ReleaseVersionsTest.testReleaseVersions
For upstream results, click here.

@jorgediaz-lr
Copy link
Author

ci:reopen

@brianchandotcom
Copy link
Owner

Merged. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jorgediaz-lr @liferay-continuous-integration @brianchandotcom