Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-69957 Do synchronized refresh to prevent concurrent refreshing de… #45905

Closed
wants to merge 1 commit into from
Closed

LPS-69957 Do synchronized refresh to prevent concurrent refreshing de… #45905

wants to merge 1 commit into from

Conversation

shuyangzhou
Copy link

…adlock between FileInstall and ModuleFrameworkImpl

@robertoDiaz @migue @juangon @tinatian

Without being able to reproduce the problem, this is my best guess for the root cause.
I am 50% sure this is it, the other 50% case is in FileInstall code. Considering this is a harmless change, so I am making it now. Please go ahead try it on your side @robertoDiaz. If the problem still exists for you, get me a new thread dump. Then most likely it is the FileInstall refresh causing it, the worst case we have to patch it. Hope we won't have to get there.

And still, it will be the best if @robertoDiaz can help @tinatian and me to reproduce it.Then I can know for sure we get the right fix in the best way.

@shuyangzhou
LPS-69957 Do synchronized refresh to prevent concurrent refreshing de…
b54df2f 
…adlock between FileInstall and ModuleFrameworkImpl
@robertoDiaz
Copy link

👍

Thank you @shuyangzhou.

I'll test it ASAP

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED.

Build Time: 1 hour 30 minutes 21 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 8206b5686e9ccd3db1cb6434140538b40a24b6fc

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    89 Jobs Passed.
    3 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/lpkg-override-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 0,!master #26625
          \[junit\] 
    \[junit\] 	at org\.eclipse\.osgi\.container\.Module\.start\(Module\.java:429\)
    \[junit\] 	at org\.eclipse\.osgi\.container\.ModuleContainer$ContainerStartLevel\.incStartLevel\(ModuleContainer\.java:1582\)
    \[junit\] 	at org\.eclipse\.osgi\.container\.ModuleContainer$ContainerStartLevel\.incStartLevel\(ModuleContainer\.java:1562\)
    \[junit\] 	at org\.eclipse\.osgi\.container\.ModuleContainer$ContainerStartLevel\.doContainerStartLevel\(ModuleContainer\.java:1533\)
    \[junit\] 	at org\.eclipse\.osgi\.container\.ModuleContainer$ContainerStartLevel\.dispatchEvent\(ModuleContainer\.java:1476\)
    \[junit\] 	at org\.eclipse\.osgi\.container\.ModuleContainer$ContainerStartLevel\.dispatchEvent\(ModuleContainer\.java:1\)
    \[junit\] 	at org\.eclipse\.osgi\.framework\.eventmgr\.EventManager\.dispatchEvent\(EventManager\.java:230\)
    \[junit\] 	at org\.eclipse\.osgi\.framework\.eventmgr\.EventManager$EventThread\.run\(EventManager\.java:340\)
    \[junit\] 
    \[junit\] 
    \[junit\] 	at com\.liferay\.portal\.log\.assertor\.PortalLogAssertorTest\.testScanOSGiLog\(PortalLogAssertorTest\.java:82\)
    \[junit\] 
    \[junit\] 
    \[junit\] Test com\.liferay\.portal\.log\.assertor\.PortalLogAssertorTest FAILED
     \[echo\] The following error occurred while executing this line:
     \[echo\] /opt/dev/projects/github/liferay\-portal/build\-test\-batch\.xml:254: The following error occurred while executing this line:
     \[echo\] /opt/dev/projects/github/liferay\-portal/build\-test\-batch\.xml:878: /opt/dev/projects/github/liferay\-portal/build\-test\-batch\.xml:880: The following error occurred while executing this line:
     \[echo\] /opt/dev/projects/github/liferay\-portal/build\-test\.xml:9294: The following error occurred while executing this line:
     \[echo\] /opt/dev/projects/github/liferay\-portal/build\-test\.xml:3074: The following error occurred while executing this line:
     \[echo\] /opt/dev/projects/github/liferay\-portal/build\-test\.xml:3173: 
     \[echo\] exec returned: 1
     \[echo\] The following error occurred while executing this line:
     \[echo\] /opt/dev/projects/github/liferay\-portal/build\-test\.xml:3538: No server is available at http://localhost:8080/web/guest
     \[echo\] $\{jstack\.output\}
      \[get\] Getting: http://test\-1\-8/job/test\-portal\-acceptance\-pullrequest\-batch\(master\)/AXIS\_VARIABLE=0,label\_exp=\!master/26625//consoleText
      \[get\] To: /opt/dev/projects/github/liferay\-portal/20170103203339767\.txt
   \[delete\] Deleting: /opt/dev/projects/github/liferay\-portal/20170103203339767\.txt
  3. test-portal-acceptance-pullrequest-batch(master)/modules-integration-sybase160-jdk8
    Job Results:

    5577 Tests Passed.
    77 Tests Failed.

    1. JournalArticleTrashHandlerTest.testTrashAndDeleteWithApprovedStatusIndexable
    2. JournalArticleTrashHandlerTest.testTrashAndDeleteWithApprovedStatusIndexableAndEqualsParentAndBaseModelClass
    3. JournalArticleTrashHandlerTest.testTrashAndDeleteWithDraftStatusIndexable
    4. ...

    Click here for more failures.

For upstream results, click here.

@shuyangzhou
Copy link
Author

Checking on the lpkg failrue, maybe real. Close this pull for now, I will resend.
@robertoDiaz please continue your test, whatever reason lpkg override is failing should be irrelevant to the deadlock issue.

@shuyangzhou shuyangzhou closed this Jan 3, 2017
@shuyangzhou shuyangzhou mentioned this pull request Jan 3, 2017
Closed
@shuyangzhou
Copy link
Author

Resent at #45917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@shuyangzhou @robertoDiaz @liferay-continuous-integration