Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-70367 Fix discussion jsps not being included from LPS-69899. #46482

Closed

Conversation

@Preston-Crary
Copy link

Preston-Crary commented Jan 31, 2017

No description provided.

@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Jan 31, 2017

Merged. Thx.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Jan 31, 2017

Unable to generate test report.

Jenkins encountered the following error while generating test report:

The following error occurred while executing this line:
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:6116: The following error occurred while executing this line:
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:1704: The following error occurred while executing this line:
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:781: Sourced file: inline evaluation of: `` 				 					import java.util.regex.Matcher; 					import java.util.regex.Pattern;  . . . '' : TargetError : at Line: 117 : in file: inline evaluation of: `` 				 					import java.util.regex.Matcher; 					import java.util.regex.Pattern;  . . . '' : throw e ; 

Target exception: java.net.ConnectException: Connection refused

Base Branch:

Branch Name: master

Branch GIT ID: af43248cbd21e4737f180de01ff5d9480094a453

Job Summary:

Job Link: test-portal-acceptance-pullrequest(master)

For more details click here.

@jbalsas

This comment has been minimized.

Copy link

jbalsas commented May 22, 2017

Hey @Preston-Crary, could you please take a look and backport this to ee-7.0.x if needed?

Thanks!

@Preston-Crary

This comment has been minimized.

Copy link
Author

Preston-Crary commented May 22, 2017

@jbalsas, it's not needed. That line didn't apply to 7.0.x.

@jbalsas

This comment has been minimized.

Copy link

jbalsas commented May 23, 2017

Hey @Preston-Crary, could you double check? https://issues.liferay.com/browse/LPS-70367 is marked as a regression last known to work in FP-10, so that should indicate that a backport is needed...

@Preston-Crary

This comment has been minimized.

Copy link
Author

Preston-Crary commented May 23, 2017

@jbalsas, I did double check. That line doesn't exist in ee-7.0.x, so there's nothing to backport. That ticket was created in January so maybe that has something to do with using FP-10 as the last working version?

@anthony-chu, does https://issues.liferay.com/browse/LPS-70367 effect ee-7.0.x?

@jbalsas

This comment has been minimized.

Copy link

jbalsas commented May 23, 2017

Thanks a lot @Preston-Crary!

@anthony-chu

This comment has been minimized.

Copy link

anthony-chu commented May 23, 2017

Hey @Preston-Crary and @jbalsas, LPS-70367 doesn't affect ee-7.0.x, as the "Subscribe to Comments" link and comment editor are present.
image

Thanks guys!

@Preston-Crary

This comment has been minimized.

Copy link
Author

Preston-Crary commented May 23, 2017

@anthony-chu, awesome, thanks for the sanity check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.