Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-70740 Revert java fix of LPS-50193: When edit one record in Spreadsheet and current locale is not default locale with old record. We need to add new defaultLocale value for this field. Otherwise, in DDMImpl.mergeFields(), the array newFieldsDisplayValues is empty. mergedLocaleValues is null so that edit value can't be saved and field value of new version record is null. #47024

Closed
wants to merge 21 commits into from

Conversation

@leoadb
Copy link

commented Feb 20, 2017

No description provided.

LPS-70740 Revert java fix of LPS-50193: When edit one record in Sprea…
…dsheet and current locale is not default locale with old record. We need to add new defaultLocale value for this field. Otherwise, in DDMImpl.mergeFields(), the array newFieldsDisplayValues is empty. mergedLocaleValues is null so that edit value can't be saved and field value of new version record is null.
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Feb 20, 2017

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

@leoadb


However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

Job Results:

2478 Tests Passed.
1 Test Failed.

  1. ReleaseVersionsTest.testReleaseVersions
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Feb 20, 2017

Some tests FAILED.

Build Time: 1 hour 17 minutes 33 seconds

Base Branch:

Branch Name: master
Branch GIT ID: e330d7f03769a98f5b54f0e4c9db8f0d907fad7d

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    97 Jobs Passed.
    3 Jobs Failed.

    [beanshell] JENKINS_LOCAL_GIT_BRANCH_CACHED=true
    [beanshell] TOP_LEVEL_GITHUB_COMMENT_ID=281058455
    [beanshell] GITHUB_PULL_REQUEST_NUMBER=47024
    [beanshell] JENKINS_GITHUB_SENDER_BRANCH_SHA=03dbe3ccefde6944ab8465c512ddaf41d26f5e83
    [beanshell] GITHUB_ORIGIN_NAME=leoadb
    [beanshell] GITHUB_RECEIVER_USERNAME=brianchandotcom
    [beanshell] TEST_BATCH_RUN_TYPE=sequential
    [beanshell] TOP_LEVEL_JOB_NAME=test-portal-acceptance-pullrequest(master)
    [beanshell] GITHUB_UPSTREAM_BRANCH_SHA=e330d7f03769a98f5b54f0e4c9db8f0d907fad7d
    [beanshell] EMAIL_LIST=qa-slave-verify-fail@liferay.com
    [beanshell] JENKINS_GITHUB_UPSTREAM_BRANCH_SHA=03dbe3ccefde6944ab8465c512ddaf41d26f5e83
    [beanshell] RUN_TEST_CASE_METHOD_GROUP_0_0=PortalSmokeUpgrade#ViewPortalSmokeArchive623
    [beanshell] JENKINS_PULL_REQUEST_DIST_NODES=cloud-10-0-112-68,cloud-10-0-11-111,cloud-10-0-11-81,cloud-10-0-13-15,cloud-10-0-19-186,cloud-10-0-14-142,cloud-10-0-16-215,cloud-10-0-112-94,cloud-10-0-110-151,cloud-10-0-16-51,cloud-10-0-14-147,cloud-10-0-113-8,cloud-10-0-12-209,cloud-10-0-112-89,cloud-10-0-19-148,cloud-10-0-112-132,cloud-10-0-16-174,cloud-10-0-110-124,cloud-10-0-19-135,cloud-10-0-19-46,cloud-10-0-11-71
    [beanshell] TOP_LEVEL_MASTER_HOSTNAME=test-1-1
    [beanshell] BUILD_DESCRIPTION=brianchandotcom - PR#47024 - Jenkins Report
    [beanshell] TOP_LEVEL_BRANCH_NAME=master-temp-20170220034325178
    [beanshell] TOP_LEVEL_BUILD_URL=https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest(master)/1513/
    [beanshell] JENKINS_GITHUB_UPSTREAM_BRANCH_NAME=master
    [beanshell] GITHUB_SENDER_USERNAME=leoadb
    [beanshell] JENKINS_GITHUB_RECEIVER_USERNAME=liferay
    [beanshell] TEST_BATCH_SIZE=1
    [beanshell] DIST_ROOT_PATH=/test-1-1
    [beanshell] TOP_LEVEL_BUILD_NUMBER=1513
    [beanshell] TOP_LEVEL_START_TIME=1487591005740
    [beanshell] JENKINS_GITHUB_PULL_REQUEST_NUMBER=0
    [beanshell] SUBREPOSITORY_CI_MERGE_FILES=
    [beanshell] TOP_LEVEL_BUILD_DESCRIPTION=brianchandotcom - PR#47024 - Jenkins Report
    [beanshell] 
       [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/json.data
  2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat80-mysql56-jdk8/37
    Job Results:

    30 Tests Passed.
    1 Test Failed.

    1. PasswordpoliciesUsecase#ViewUserAccountLockout - Poshi Report - Poshi Summary - Console Output
  3. test-portal-acceptance-pullrequest-batch(master)/unit-jdk8
    Job Results:

    2478 Tests Passed.
    1 Test Failed.

    1. ReleaseVersionsTest.testReleaseVersions
For upstream results, click here.
@leoadb

This comment has been minimized.

Copy link
Author

commented Feb 20, 2017

ci:reopen

@brianchandotcom

This comment has been minimized.

Copy link
Owner

commented Feb 20, 2017

Merged. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.