Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-70635 SF - Add missing lang keys #48638

Closed
wants to merge 9 commits into from

Conversation

rafaprax
Copy link

@rafaprax rafaprax commented Apr 26, 2017

\cc @leoadb

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

All tests PASSED.

Build Time: 1 hour 42 minutes 55 seconds 970 ms

Base Branch:

Branch Name: master
Branch GIT ID: ea4f3a50659e6a46585d986787b453bd8968fe3d

Job Summary:

For more details click here.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 3119864...cffbd8d

@brianchandotcom
Copy link
Owner

@rafaprax @leoadb

Can we change

belongsTo('Role1','Role2')

to

belongsTo('Role1', 'Role2')

Can you send a follow up pull and clean that up?

It is in modules/apps/forms-and-workflow/dynamic-data-lists/dynamic-data-lists-form-web/src/test/resources/com/liferay/dynamic/data/lists/form/web/internal/converter/dependencies/ddl-form-rules-belongs-to-condition.json

and

modules/apps/forms-and-workflow/dynamic-data-lists/dynamic-data-lists-form-web/src/test/resources/com/liferay/dynamic/data/lists/form/web/internal/converter/dependencies/ddm-form-rules-belongs-to-condition.json

Thx @rafaprax

@rafaprax
Copy link
Author

rafaprax commented May 2, 2017

done #48744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants