Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-72456 Update Find Security Bugs with definitions from knowledge-base module #48926

Closed
wants to merge 4 commits into from

Conversation

@topolik
Copy link

commented May 11, 2017

Hi Brian,

only findsecbugs changes.

Based on #48900 (comment):

Can you add "@generated" to the patched files via your patch?

See the other patches, by doing that, you don't need the SF exclude.

Can you also send this as 2 pulls, one to modify findsecbugs, which I will backport right away, and the KB changes which I will need you to backport.

Thanks.

https://issues.liferay.com/browse/LPS-72456

Btw. thank you for the @generated hint

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented May 11, 2017

@topolik topolik changed the title LPS-72456 LPS-72456 Update Find Security Bugs with definitions from knowledge-base module May 11, 2017

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented May 11, 2017

All tests PASSED.

Build Time: 1 hour 35 minutes 5 seconds 671 ms

Base Branch:

Branch Name: master
Branch GIT ID: e916d62692f6eb12139c4d8117c194b34c7686c4

Job Summary:

For more details click here.
@brianchandotcom

This comment has been minimized.

Copy link
Owner

commented May 11, 2017

Merged. Thank you.
View total diff: 70facf1...517b59b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.