Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

LPS-26756 #4914

wants to merge 3 commits into


None yet
2 participants

migue commented Apr 10, 2012

No description provided.


brianchandotcom commented May 31, 2012

Hey Miguel,

Sorry it took so long to review this pull. I need you to do a few changes before I can move it in:

1.) Currently, to update the Tomcat libs, I download the latest tomcat, look through versions.xml and search for Tomcat, and then replace a few libraries. But, with this change, the number of libs is much larger now, which will make upgrades much more difficult.

I'd like to script that. So in portal-impl/build.xml , add a target called "ant upgrade-lib-tomcat", which will download the necessary jars, and update everything. We will still check it in, but I wanted to "document" the logic somewhere.

2.) I know that Ray is working on OSGi stuff related to this. I want to make sure this is in line with it. I don't think the Tomcat classes should be in util-java. We should probably add it to support-tomcat.

Then, let's add a task that will create a liferay "jar". (add it to build-dist.xml). Now, I want to be able to do "java -jar liferay.jar" and have it start up Liferay using Tomcat natively.

3.) Then let's add the necessary configs to automate this for test envs.

Can you do 1, 2, and 3 as three separate commits?

Thx Miguel.


brianchandotcom commented May 31, 2012

I should have written this much sooner, but I was trying to do these 3 things myself and never had time. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment