New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-77634 #55268
LPS-77634 #55268
Conversation
Using variables to record derived information introduces order dependencies in the logic, as consumers of those variables depend on them having been previously set. Deriving information on demand where feasible can help alleviate this problem.
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
ci:test |
Pull request test invoked at http://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest(master). |
Some tests FAILED.Build Time: 3 hours 2 minutes 57 seconds 538 ms Base Branch:Branch Name: master Copied in Private Modules Branch:Branch Name: master-private 10 Failed Jobs:
110 Successful Jobs:
For more details click here.Failures unique to this pull:
|
Merged. Thank you. |
@noahsherrillwork please see my changes in upstream, next wave should be easier for me to review now. Thx! |
This is the revision based on our discussion concerning #55023.
/cc @drewbrokke @pei-jung @willnewbury