Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-78578 We don't need to use resourceBundle since we have all language keys in site-navigation-lang #55968

Closed
wants to merge 1 commit into from

Conversation

@ealonso
Copy link

ealonso commented Mar 8, 2018

No description provided.

…age keys in site-navigation-lang
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Mar 8, 2018

CI is automatically triggering "ci:test:sf" for this pull to run Source Formatter tests.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Mar 8, 2018

@ealonso

This comment has been minimized.

Copy link
Author

ealonso commented Mar 8, 2018

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Mar 8, 2018

All tests PASSED.

Build Time: 11 minutes 1 second 932 ms

Base Branch:

Branch Name: master
Branch GIT ID: 4c17810190d8c3c3c89b4bc55560e009509db5a4

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 6295d6a149a7527a3084dee98f67c1d0fdb3e60b

2 out of 2 jobs PASSED
2 Successful Jobs:
For more details click here.
@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Mar 9, 2018

Merged. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.