Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-83379 Enabled by default #61609

Conversation

4lejandrito
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 35 seconds 486 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d9f0a8fa1d5d7cf77760dedf4d2a591ad33072fd

Sender Branch:

Branch Name: LPS-83379-with-shuyang-changes
Branch GIT ID: e91108cdf408e0395de52fb45e18344e3e2b2209

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 20 out of 23 jobs passed in 1 hour 17 minutes 4 seconds 154 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d9f0a8fa1d5d7cf77760dedf4d2a591ad33072fd

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: da9b557aadf171209e5fa49bb89fdb13ddee0143

20 out of 23 jobs PASSED
20 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at d9f0a8f:

@shuyangzhou
Copy link

@4lejandrito can you make a follow up change to limit how many times we relaunch the tensorflow jvm? Just in case some special image could cause it crashing, and people use it to create a DDoS to us. Make the limits configurable, and once we reach that limit, just disable the tagger to prevent it from being used further.

CC @aaragueslr @mhan810

@4lejandrito
Copy link
Author

Hi @shuyangzhou ,

I'll do after @brianchandotcom merges it if that's ok.

Regards

@shuyangzhou
Copy link

Yeah, that's fine. Just add it to your queue and make sure it goes in before next fix pack release. Thanks!

@4lejandrito
Copy link
Author

Cool, I'll do it tomorrow most likely. Just for your info, this is a new feature for 7.2 so it won't make it to any fix pack for the moment.

@shuyangzhou
Copy link

Hmm, Brian is still auto back porting to 7.1, right? If it goes into master, it means going in 7.1 too.

@4lejandrito
Copy link
Author

Nothing related to this new autotagging feature has been backported. @sergiogonzalez told us that he had green light from @brianchandotcom to start sending new features as long as they were in separate modules. Maybe @brianchandotcom can clarify this just in case.

@shuyangzhou
Copy link

OK, that's good! Then you have plenty time to work on it.

@brianchandotcom
Copy link
Owner

Merged. Thank you.

View just my changes: 4lejandrito:7d1cafe184...37194b9
View total diff: 12fb903...37194b9

@brianchandotcom
Copy link
Owner

@4lejandrito I made a lot of changes in upstream. I also used a new ticket for 4e789e6 and backported it since it doesn't necessarily have anything to do with this ticket.

@petershin see fa22b37 not sure why SF didn't catch that

@petershin
Copy link

@brianchandotcom - There isn't a check to auto sort language keys. Will send a patch

@jpince
Copy link
Collaborator

jpince commented Jul 27, 2018

@4lejandrito I see this error in the upgrade console log, can you please resolve? Looks like it only affects upgrades.

     [exec] 14:01:36,882 ERROR [main][com_liferay_document_library_asset_auto_tagger_tensorflow:97] [com.liferay.document.library.asset.auto.tagger.tensorflow.internal.util.InceptionImageLabeler(1646)] The activate method has thrown an exception 
     [exec] java.nio.file.FileAlreadyExistsException: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/org.eclipse.osgi/400/data/tensorflow-workdir/libtensorflow-1.8.0.jar

Console Log

cc/ @austinchiang (this is master-only. Doesn't fail test but errors are present in the log.)

@jpince
Copy link
Collaborator

jpince commented Jul 30, 2018

@shuyangzhou
Copy link

It is fixed here #61694

@shuyangzhou
Copy link

it is a dirty shutdown in the upgrade, that is still a problem, this fix is only making sure we can peacefully recover from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants