Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-82333 Sites which inherit locales shouldn't get/set. Retrieve di… #62828

Closed
wants to merge 1 commit into from

Conversation

shuyangzhou
Copy link

…rectly from company locales instead.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@brianchandotcom
Copy link
Owner

Merged. Thx.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 51 seconds 584 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e22d21bba16f1bc451bd81a917aed902e385a617

Sender Branch:

Branch Name: LPS-82333-2
Branch GIT ID: c941721f4e9e2a6b8f305582e8a4af32747a0348

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

@shuyangzhou


However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

test-portal-acceptance-pullrequest-dist(master)/dist-jdk8
Job Results:

0 Tests Passed.
1 Test Failed.

  1. AXIS_VARIABLE=tomcat,label_exp=!master #2829
         [exec] Note: Some input files use unchecked or unsafe operations.
         [exec] Note: Recompile with -Xlint:unchecked for details.
         [exec] :apps:sharing:sharing-document-library:jar
         [exec] :apps:sharing:sharing-document-library:deploy
         [exec] Files of project ':apps:sharing:sharing-document-library' deployed to /opt/dev/projects/github/liferay-portal/bundles/osgi/modules
         [exec] :apps:sharing:sharing-document-library:deployDependencies UP-TO-DATE
         [exec] :apps:sharing:sharing-search:compileJava
         [exec] :apps:portlet-configuration:portlet-configuration-css-web:transpileJS
         [exec] :apps:sharing:sharing-service:compileJava
         [exec] :apps:sharing:sharing-search:copyLibs SKIPPED
         [exec] :apps:sharing:sharing-search:classes
         [exec] :apps:sharing:sharing-search:jarRunning 'build'...
         [exec] Compiling soy
         [exec] /opt/dev/projects/github/liferay-portal/modules/apps/sharing/sharing-service/src/main/java/com/liferay/sharing/service/impl/SharingEntryLocalServiceImpl.java:298: error: local variables referenced from a lambda expression must be final or effectively final
         [exec] 			actionIds -> sharingEntry.setActionIds(actionIds)
         [exec] 			             ^
         [exec] 
         [exec] :apps:sharing:sharing-search:deploy
         [exec] Files of project ':apps:sharing:sharing-search' deployed to /opt/dev/projects/github/liferay-portal/bundles/osgi/modules
         [exec] :apps:sharing:sharing-search:deployDependencies UP-TO-DATE
         [exec] :apps:site-navigation:site-navigation-service:buildCSS UP-TO-DATE
         [exec] Note: /opt/dev/projects/github/liferay-portal/modules/apps/sharing/sharing-service/src/main/java/com/liferay/sharing/service/persistence/impl/SharingEntryPersistenceImpl.java uses unchecked or unsafe operations.
         [exec] Note: Recompile with -Xlint:unchecked for details.
         [exec] 1 error
         [exec] :apps:site-navigation:site-navigation-service:processResources
         [exec] :apps:site-navigation:site-navigation-service:transpileJS SKIPPED
         [exec] :apps:site-navigation:site-navigation-service:configJSModules SKIPPED
         [exec] :apps:site-navigation:site-navigation-service:copyLibs SKIPPED
         [exec] :apps:site-navigation:site-navigation-service:replaceSoyTranslation UP-TO-DATE
         [exec] :apps:site-navigation:site-navigation-service:wrapSoyAlloyTemplate SKIPPED
         [exec] :apps:site-navigation:site-navigation-service:classes
         [exec] :apps:site-navigation:site-navigation-service:jar

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 0 out of 2 jobs passed in 32 minutes 53 seconds 803 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e22d21bba16f1bc451bd81a917aed902e385a617

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 3aaaf63b3827ae8bf66a729ba08ea14d5b5bf09f

0 out of 2 jobs PASSED
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-dist(master)/dist-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=tomcat,label_exp=!master #2829
           [exec] Note: Some input files use unchecked or unsafe operations.
           [exec] Note: Recompile with -Xlint:unchecked for details.
           [exec] :apps:sharing:sharing-document-library:jar
           [exec] :apps:sharing:sharing-document-library:deploy
           [exec] Files of project ':apps:sharing:sharing-document-library' deployed to /opt/dev/projects/github/liferay-portal/bundles/osgi/modules
           [exec] :apps:sharing:sharing-document-library:deployDependencies UP-TO-DATE
           [exec] :apps:sharing:sharing-search:compileJava
           [exec] :apps:portlet-configuration:portlet-configuration-css-web:transpileJS
           [exec] :apps:sharing:sharing-service:compileJava
           [exec] :apps:sharing:sharing-search:copyLibs SKIPPED
           [exec] :apps:sharing:sharing-search:classes
           [exec] :apps:sharing:sharing-search:jarRunning 'build'...
           [exec] Compiling soy
           [exec] /opt/dev/projects/github/liferay-portal/modules/apps/sharing/sharing-service/src/main/java/com/liferay/sharing/service/impl/SharingEntryLocalServiceImpl.java:298: error: local variables referenced from a lambda expression must be final or effectively final
           [exec] 			actionIds -> sharingEntry.setActionIds(actionIds)
           [exec] 			             ^
           [exec] 
           [exec] :apps:sharing:sharing-search:deploy
           [exec] Files of project ':apps:sharing:sharing-search' deployed to /opt/dev/projects/github/liferay-portal/bundles/osgi/modules
           [exec] :apps:sharing:sharing-search:deployDependencies UP-TO-DATE
           [exec] :apps:site-navigation:site-navigation-service:buildCSS UP-TO-DATE
           [exec] Note: /opt/dev/projects/github/liferay-portal/modules/apps/sharing/sharing-service/src/main/java/com/liferay/sharing/service/persistence/impl/SharingEntryPersistenceImpl.java uses unchecked or unsafe operations.
           [exec] Note: Recompile with -Xlint:unchecked for details.
           [exec] 1 error
           [exec] :apps:site-navigation:site-navigation-service:processResources
           [exec] :apps:site-navigation:site-navigation-service:transpileJS SKIPPED
           [exec] :apps:site-navigation:site-navigation-service:configJSModules SKIPPED
           [exec] :apps:site-navigation:site-navigation-service:copyLibs SKIPPED
           [exec] :apps:site-navigation:site-navigation-service:replaceSoyTranslation UP-TO-DATE
           [exec] :apps:site-navigation:site-navigation-service:wrapSoyAlloyTemplate SKIPPED
           [exec] :apps:site-navigation:site-navigation-service:classes
           [exec] :apps:site-navigation:site-navigation-service:jar

For upstream results, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants