LPS-84879 SF #64070

brunobasto · 2018-10-11T21:05:04Z

No description provided.

…n evaluator field is edited

…mponent

… avoid closing the Sidebar when the clicked component is part of some sidebar children component

…t a clicked field

…he backend when the edited field is evaluable

… of some objects or arrays

…idebar component

… fields, with a new one

…s interators methods

…epeatable property

…nt based on the tooltip icon

… be used to show the tooltip information if the field has these properties

…ectations

…tyle as the old form has

liferay-continuous-integration · 2018-10-11T21:05:07Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2018-10-11T21:07:57Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 53 seconds 460 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e7781966d1aa1208b77547aa991ece95ef2155d8

Sender Branch:

Branch Name: pr-937
Branch GIT ID: 12cded7510a26466a203c8dca466e9d330978d99

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

brianchandotcom · 2018-10-11T21:31:33Z

Merged. Thank you.
View total diff: 879b9ad...abca74c

brianchandotcom · 2018-10-11T21:37:17Z

Hey guys, this ticket contains

LPS-84879, which was already backported by support. Please do not forget to backport these changes too!

@brunobasto fyi!

liferay-continuous-integration · 2018-10-11T21:59:01Z

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

test-portal-acceptance-pullrequest(master)

@brunobasto

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

portal-frontend-js-jdk8

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/portal-frontend-js-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #263037

     [exec] -------------------------------------------------------------------|----------|----------|----------|----------|-------------------|
     [exec] Snapshot Summary
     [exec]  ??? 24 snapshots failed from 3 test suites. Inspect your code changes or run `npm test -- -u` to update them.
     [exec] 
     [exec] Test Suites: 3 failed, 8 passed, 11 total
     [exec] Tests:       24 failed, 92 passed, 116 total
     [exec] Snapshots:   24 failed, 77 passed, 101 total
     [exec] Time:        9.751s
     [exec] Ran all test suites.
     [exec] npm ERR! code ELIFECYCLE
     [exec] npm ERR! errno 1
     [exec] npm ERR! dynamic-data-mapping-form-field-type@4.0.0 test: `npm run build-soy-tests && NODE_ENV=test jest --coverage && npm run clean`
     [exec] npm ERR! Exit status 1
     [exec] npm ERR! 
     [exec] npm ERR! Failed at the dynamic-data-mapping-form-field-type@4.0.0 test script.
     [exec] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
     [exec] 
     [exec] npm ERR! A complete log of this run can be found in:
     [exec] npm ERR!     /root/.npm/_logs/2018-10-11T21_58_10_837Z-debug.log
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:dynamic-data-mapping:dynamic-data-mapping-form-field-type:npmRunTest'.
     [exec] > java.io.IOException: Process '[/opt/dev/projects/github/liferay-portal/build/node/bin/node, /opt/dev/projects/github/liferay-portal/build/node/lib/node_modules/npm/bin/npm-cli.js, run-script, test, --loglevel, warn, --progress, true, --registry, http://mirrors.lax.liferay.com:4873]' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:dynamic-data-mapping:dynamic-data-mapping-form-field-type:npmRunTest'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:98)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:68)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)

liferay-continuous-integration · 2018-10-11T22:45:12Z

❌ ci:test:relevant - 39 out of 46 jobs passed in 1 hour 40 minutes 37 seconds 757 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b6329ef59a03c43bc9a890312a2feee06caab19d

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 504720c89bc335ecdda0e9f1ccde789cba898c05

39 out of 46 jobs PASSED

7 Failed Jobs:

39 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/13
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #176620
  1. LocalFile.FormRules#ConfigureShowRuleUsingAndCondition - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/19
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #176621
  1. LocalFile.Forms#SubmitFormAndViewEmailNotification - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/20
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #240757
  1. LocalFile.FormsUpgrade#ViewAndDeleteFormEntryAfterUpgrade70106 - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/21
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #225898
  1. LocalFile.FormsUpgrade#ViewAndDeleteFormEntryAfterUpgrade704 - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/4
Job Results:
17 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=1,label_exp=!master #263035
  1. LocalFile.Forms#SubmitFormAfterEditingFields - Poshi Report - Poshi Summary - Console Output
...

For upstream results, click here.

brunobasto · 2018-10-12T01:06:52Z

Hey @brianchandotcom, LPS-84879 is a story ticket. It's not supposed to go to 7.1.x. Did you misspelled the ticket number?

jpince · 2018-10-12T15:57:30Z

@brunobasto @clovisdasilvaneto I'm pretty sure this pull broke frontend-js, can you please take a look?
A lot of the errors look like this:

     [exec]     -     <input class="form-control" name="textField" type="text" disabled="disabled" value="">
     [exec]     +     <input class="form-control" name="textField" type="text" value="">

https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/263037//consoleText

brunobasto · 2018-10-13T00:24:25Z

Thanks for catching that, @jpince. I'll take a look and send a follow up pr.

brunobasto · 2018-10-13T00:28:08Z

Fix sent here: #64113

clovisdasilvaneto and others added 30 commits October 11, 2018 13:22

LPS-84277 Set the default state of page success settings feature

b1a14c5

LPS-84277 SF

1b997ed

LPS-84277 Adjust npm project dependencies

6d9dfd3

LPS-84277 Create evaluator feature in order to evaluate a form when a…

baf9c67

…n evaluator field is edited

LPS-84277 Add the field settings actions on the top of the sidebar co…

5cf0dbc

…mponent

LPS-84277 Adjust handleDocummentClick method on Sidebar component, to…

726fd4b

… avoid closing the Sidebar when the clicked component is part of some sidebar children component

LPS-84277 Add a fieldClicked event in order to allows the user to edi…

0774d18

…t a clicked field

LPS-84277 Use evaluator component on sidebar for making requests to t…

1d7520e

…he backend when the edited field is evaluable

LPS-84277 Adjust application methods in order to not mutate the state…

9e794ac

… of some objects or arrays

LPS-84277 Change the focusedField when the field is edited from the s…

f171115

…idebar component

LPS-84277 Create mergeFields method to merge the old context from the…

f5d4283

… fields, with a new one

LPS-84277 Create fieldSupport util in order to reuse it in some field…

d7c0d3d

…s interators methods

LPS-84277 Create tests in order to coverage the edit field functionality

aadbb37

LPS-84277 Generated snapshots

1203320

LPS-84277 Create mockPages file in order to use it on form builder test

1d9180b

LPS-84277 SF

058f404

LPS-84277 Generated package-lock

538cdcd

LPS-84277 Fix .npmbundlerrc file

1f13fe3

LPS-84879 Create Tooltip component in order to reuse it on fields types

55f5d3d

LPS-84879 Adjust fields types in order to allow them to receive the r…

55ac2dc

…epeatable property

LPS-84879 Add metal-position depency for aligning the tooltip compone…

0acf7d2

…nt based on the tooltip icon

LPS-84879 Adjust fieldbase properties adding the properties wich will…

38d7fcf

… be used to show the tooltip information if the field has these properties

LPS-84879 Adjust tooltip design in order to fit the design review exp…

6a3ce50

…ectations

LPS-84879 Adjust repeatable button style, in order to have the same s…

9b60c25

…tyle as the old form has

LPS-84879 Adjust CSS files CSS files modularizing them

9f23c7c

LPS-84879 Increase project coverage

732c754

LPS-84879 Generated snapshots

4a7600a

LPS-84879 Avoid generated field name on tests snapshots

974494f

LPS-84879 Generated snapshots

c33b3be

LPS-84879 Auto SF

a7af0d2

Bruno Basto added 4 commits October 11, 2018 13:54

LPS-84879 SF - Move non generic methods out of util package

8aa227d

LPS-84879 Makes sure sidebar opens when a field is clicked

e86114d

LPS-84879 Fix broken tests

ea1d6b5

LPS-84879 SF

12cded7

brunobasto mentioned this pull request Oct 11, 2018

LPS-84277 Generated package-lock brunobasto/liferay-portal#937

Closed

liferay-continuous-integration added ci:test:relevant - pending ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Oct 11, 2018

brianchandotcom closed this Oct 11, 2018

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels Oct 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-84879 SF #64070

LPS-84879 SF #64070

brunobasto commented Oct 11, 2018

liferay-continuous-integration commented Oct 11, 2018

liferay-continuous-integration commented Oct 11, 2018

Base Branch:

Sender Branch:

For more details click here.

brianchandotcom commented Oct 11, 2018

brianchandotcom commented Oct 11, 2018

liferay-continuous-integration commented Oct 11, 2018

test-portal-acceptance-pullrequest-batch(master)/portal-frontend-js-jdk8

Job Results:

liferay-continuous-integration commented Oct 11, 2018

Base Branch:

Copied in Private Modules Branch:

7 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/13

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/19

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/20

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/21

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/4

Job Results:

For upstream results, click here.

brunobasto commented Oct 12, 2018

jpince commented Oct 12, 2018

brunobasto commented Oct 13, 2018

brunobasto commented Oct 13, 2018

LPS-84879 SF #64070

LPS-84879 SF #64070

Conversation

brunobasto commented Oct 11, 2018

liferay-continuous-integration commented Oct 11, 2018

liferay-continuous-integration commented Oct 11, 2018

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 53 seconds 460 ms

Base Branch:

Sender Branch:

For more details click here.

brianchandotcom commented Oct 11, 2018

brianchandotcom commented Oct 11, 2018

liferay-continuous-integration commented Oct 11, 2018

The pull request tester is still running.

However, the pull request was closed.

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/portal-frontend-js-jdk8

Job Results:

liferay-continuous-integration commented Oct 11, 2018

❌ ci:test:relevant - 39 out of 46 jobs passed in 1 hour 40 minutes 37 seconds 757 ms

Base Branch:

Copied in Private Modules Branch:

7 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/13

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/19

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/20

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/21

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/4

Job Results:

For upstream results, click here.

brunobasto commented Oct 12, 2018

jpince commented Oct 12, 2018

brunobasto commented Oct 13, 2018

brunobasto commented Oct 13, 2018