Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-86622 Getting nodeId parameter from the portlet request #64652

Closed
wants to merge 1 commit into from

Conversation

@4lejandrito
Copy link

4lejandrito commented Oct 30, 2018

No description provided.

This is a temporary fix. I have created
https://issues.liferay.com/browse/LPS-86811 to investigate a better
solution for it. But we can solve the bug for now.

Explanation:

The file uploader is sending the nodeId parameter as:

    p_r_p_http://www.liferay.com/public-render-parameters/wiki_nodeId

And the uploadPortletRequest returns null when queried for "nodeId". The
same returns the right value when called on the portletRequest.
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Oct 30, 2018

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Oct 30, 2018

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 6 seconds 339 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 01f27046f30cec8a83cc0a64299ed9713e0c48da

Sender Branch:

Branch Name: LPS-86622-3
Branch GIT ID: a81fa637a2766f81d6335fa06e7ec45157a1718b

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.
@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Oct 30, 2018

Merged. Thank you.
View total diff: 01f2704...282658f

@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Oct 30, 2018

@ngriffin7a can you help out @4lejandrito I wonder if this has to do with the portlet 3 stuff?

Thx!

@4lejandrito

This comment has been minimized.

Copy link
Author

4lejandrito commented Oct 30, 2018

@ngriffin7a, @brianchandotcom FYI:

I have created https://issues.liferay.com/browse/LPS-86811 for it and was working on a potential fix, see shuyangzhou#6971.

Thanks!

@ngriffin7a

This comment has been minimized.

Copy link

ngriffin7a commented Oct 30, 2018

@brianchandotcom @4lejandrito I'll take a look.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Oct 30, 2018

ci:test:relevant - 21 out of 23 jobs passed in 1 hour 23 minutes 44 seconds 121 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 01f27046f30cec8a83cc0a64299ed9713e0c48da

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 294489cf97e35502549b725030cd74ac7bc26583

21 out of 23 jobs PASSED
21 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 209fe1d:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8
    Job Results:

    197 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #257090
      1. ProjectTemplatesTest.testBuildTemplateRest71
        java.lang.AssertionError: [INFO] Error stacktraces are turned on.
        [INFO] Scanning for projects...
        [INFO] 
        [INFO] ------------------------------------------------------------------------
        [INFO] Building Maven Stub Project (No POM) 1
        [INFO] ------------------------------------------------------------------------
        [INFO] 
        [INFO] >>> maven-archetype-plugin:3.0.1:generate (default-cli) > generate-sources @ standalone-pom >>>
        [INFO] 
        [INFO] <<< maven-archetype-plugin:3.0.1:generate (default-cli) < generate-sources @ standalone-pom <<<
        [INFO] 
        [INFO] 
        [INFO] --- maven-archetype-plugin:3.0.1:generate (default-cli) @ standalone-pom ---
        [INFO] Generating project in Batch mode
        [INFO] Archetype repository not defined. Using the one from [com.liferay:com.liferay.project.templates.rest:1.0.9 -> https://repository-cdn.liferay.com/nexus/content/groups/public] found in catalog remote
        [INFO] ----------------------------------------------------------------------------
        [INFO] Using following parameters for creating project from Archetype: com.liferay.project.templates.rest:1.0.18
        [INFO] ----------------------------------------------------------------------------
        [INFO] Parameter: groupId, Value: com.test
        [INFO] Parameter: artifactId, Value: my-rest
        [INFO] Parameter: version, Value: 1.0.0
        [INFO] Parameter: package, Value: my.rest
        [INFO] Parameter: packageInPathFormat, Value: my/rest
        [INFO] Parameter: liferayVersion, Value: 7.1
        [INFO] Parameter: author, Value: root
        [INFO] Parameter: groupId, Val...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.