Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lps 86863 #64700

Closed
wants to merge 6 commits into from
Closed

Lps 86863 #64700

wants to merge 6 commits into from

Conversation

@shuyangzhou
Copy link

shuyangzhou commented Oct 31, 2018

No description provided.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Oct 31, 2018

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Oct 31, 2018

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 50 seconds 645 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6c511378af64947fe3e661b8c7fbc4d84f9cede4

Sender Branch:

Branch Name: LPS-86863
Branch GIT ID: 8e5b1a355ac691201f843dac1e4885b4334d7f43

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.
@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Oct 31, 2018

Merged. Thank you.
View total diff: 6c51137...362bd47

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Oct 31, 2018

✔️ ci:test:relevant - 19 out of 19 jobs passed in 1 hour 9 minutes 32 seconds 780 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6c511378af64947fe3e661b8c7fbc4d84f9cede4

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 5c9fb5b99668bafc50b5488721174622d7ebc735

19 out of 19 jobs PASSED
19 Successful Jobs:
For more details click here.
@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Nov 1, 2018

@mtambara see 6a6d1b7

I found one error, and also renamed them to match our existing pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.