Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lps 89878 #67386

Closed
wants to merge 8 commits into from

Conversation

Projects
None yet
4 participants
@shuyangzhou
Copy link

commented Jan 30, 2019

No description provided.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Jan 30, 2019

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Jan 30, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 55 seconds 169 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 38549be89dbeff690aeaccbcdf1253eac89f1adc

Sender Branch:

Branch Name: LPS-89878
Branch GIT ID: bff0b99379cba1fdc6eecce3a761adb931b4f738

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.
@brianchandotcom

This comment has been minimized.

Copy link
Owner

commented Jan 30, 2019

Merged. Thx.

@brianchandotcom

This comment has been minimized.

Copy link
Owner

commented Jan 30, 2019

Beautiful @Preston-Crary ! Can you apply to modules/private/apps/portal-workflow/portal-workflow-reports/build.gradle in master-private?

Also, I need a backport for 7.1.x. If an external project has compileInclude, and they don't make the change, does it break stuff?

@Preston-Crary

This comment has been minimized.

Copy link

commented Jan 31, 2019

@brianchandotcom "If an external project has compileInclude, and they don't make the change, does it break stuff?"

Nope, I had to leave one like that in this pull.

I'll try to send a pull for master-private sometime this week. I think we have to avoid backporting this because of 43349da and 0d23d6a.

@Preston-Crary

This comment has been minimized.

Copy link

commented Jan 31, 2019

I guess we can backport it, I'll just have to create a replacement implementation for the JSONValidator interface.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Jan 31, 2019

ci:test:relevant - 73 out of 81 jobs passed in 2 hours 36 minutes 15 seconds 88 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 38549be89dbeff690aeaccbcdf1253eac89f1adc

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: c7450a46938401ac27a086af6d4cffb902106bc3

73 out of 81 jobs PASSED
73 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/49
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #265793
      start-elasticsearch-node:
           [echo] The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:340: The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1240: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1244: The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:46: The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:54: The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:10554: The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/build-test-elasticsearch6.xml:583: Elasticsearch server failed to initialize.
            [get] Getting: http://test-1-6/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/265793//consoleText
            [get] To: /opt/dev/projects/github/liferay-portal/20190131245515194.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/20190131245515194.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/null375325013.properties
  2. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
    Job Results:

    2007 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=3,label_exp=!master #266525
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.adaptive.media.exception.AMRuntimeException$IOException: com.liferay.document.library.kernel.exception.NoSuchFileEntryException: No DLFileEntry exists with the primary key 42839
        com.liferay.adaptive.media.exception.AMRuntimeException$IOException: com.liferay.document.library.kernel.exception.NoSuchFileEntryException: No DLFileEntry exists with the primary key 42839
        	at com.liferay.adaptive.media.image.internal.processor.AMImageProcessorImpl.process(AMImageProcessorImpl.java:137)
        	at com.liferay.adaptive.media.image.internal.processor.AMImageProcessorImpl.lambda$process$0(AMImageProcessorImpl.java:76)
        	at java.util.ArrayList.forEach(ArrayList.java:1249)
        	at com.liferay.adaptive.media.image.internal.processor.AMImageProcessorImpl.process(AMImageProcessorImpl.java:75)
        	at com.liferay.adaptive.media.image.internal.processor.AMImageProcessorImpl.process(AMImageProcessorImpl.java:43)
        	at com.liferay.adaptive.media.web.internal.messaging.AMProcessorCommand$2.execute(AMProcessorCommand.java:43)
        	at com.liferay.adaptive.media.web.internal.messaging.AMMessageListener.doReceive(AMMessageListener.java:77)
        	at com.liferay.portal.kernel.messaging.BaseMessageListener.receive(BaseMessageListener.java:26)
        	at com.liferay.portal.kernel.messaging.InvokerMessageListener.receive(InvokerMessageListener.java:74)
        	at com.liferay.portal.kernel.messaging.ParallelDestination$1.run(ParallelDestination.java:52)
        	at com.liferay.portal.kernel.concurrent...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.