Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-86795 Fix Clay design inconsistencies in screen navigation taglib #68138

Closed
wants to merge 11 commits into from
Closed

LPS-86795 Fix Clay design inconsistencies in screen navigation taglib #68138

wants to merge 11 commits into from

Conversation

stsquared99
Copy link

No description provided.

Samuel Tran and others added 11 commits February 15, 2019 11:03
Revert "LPS-86795 Screen Navigation Taglib Vertical Nav should collap…
643f040 
…se at breakpoint lg (991px)"

This reverts commit 7bca86b.
Revert "LPS-86795 frontend-taglib - Add proper Clay CSS formatting to…
700f096 
… screen navigation container"

This reverts commit bd44bd2.
LPS-86795 frontend-taglib - Add parentContainerCssClass attribute to …
643fa6f 
…screen-navigation taglib
LPS-86795 frontend-taglib - Add headerContainerCssClass attribute to …
bdf1f96 
…screen-navigation taglib
LPS-86795 frontend-taglib - Add menuBarCssClass attribute to screen-n…
5d0cad0 
…avigation taglib
LPS-86795 users-admin-web - Implement css classes in screen-navigatio…
96ec0e2 
…n taglibs
@pat270
LPS-86795 Source Formatting rename new taglib attributes to be more d…
d460584 
…escriptive
LPS-86795 - Update taglib attribute to be more descriptive
b4e5478
LPS-86795 - Use updated taglib attribute
efb6af6
LPS-86795 frontend-taglib - Auto SF
44f02f5
LPS-86795 frontend-taglib - SF
554f3c3
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 10 seconds 761 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bfc0b1dedff421bdea22abd02edc1ac567b5119d

Sender Branch:

Branch Name: master-LPS-86795
Branch GIT ID: 554f3c3b4a75e7754676ae97866b33cae3ffacd3

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 75a632c...4e59cc7

@stsquared99
Copy link
Author

FYI @marco-leo

@marco-leo
Copy link

@stsquared99 Can we backport to 7.1.x?

@stsquared99
Copy link
Author

@marco-leo Yep, I am taking care of it immediately

@marco-leo
Copy link

@stsquared99 Thanks!

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 75 out of 83 jobs passed in 2 hours 7 minutes 15 seconds 954 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bfc0b1dedff421bdea22abd02edc1ac567b5119d

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: fc342b4033383386436c0737022193b6a8215b5d

75 out of 83 jobs PASSED
75 Successful Jobs:
For more details click here.

Failures unique to this pull:

  6. ...

For upstream results, click here.

@jonmak08 jonmak08 mentioned this pull request Feb 15, 2019
Closed
@stsquared99 stsquared99 deleted the master-LPS-86795 branch March 7, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
5 participants
@stsquared99 @liferay-continuous-integration @brianchandotcom @marco-leo @pat270