Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-90252 ConfigurationProvider - Retrieve configurations at different scopes using ConfigurationAdmin properties #69556

Closed

Conversation

@drewbrokke
Copy link

commented Mar 14, 2019

drewbrokke and others added 14 commits Feb 14, 2019
LPS-90252 portal-configuration-settings - adds ScopedConfigurationMan…
…ager to handle creating and updating configuration objects at different scopes
LPS-90252 portal-configuration-settings - SettingsLocatorHelperImpl -…
… uses ScopedConfigurationManager instances to return settings for different scopes
LPS-90252 portal-configuration-settings-test - updates test cases to …
…account for the new way of storing scoped configurations as factory instances
LPS-90252 portal-configuration-metatype-api - ExtendedObjectClassDefi…
…nition - gives each scope a property key to be used when setting properties for the factory instances
LPS-90252 portal-configuration-test-util - ConfigurationTestUtil.java…
… - adds additional methods for creating and updating factory configurations
LPS-90252 portal-configuration-module-configuration - ConfigurationPr…
…oviderImpl - saves scoped configurations as factory instances
LPS-90252 portal-configuration-settings - ScopedConfigurationManager.…
…java - can store multiple configuration instances in a single scope, and will return the most recently updated one
LPS-90252 portal-configuration-settings-test - adds additional test c…
…ase to account for the "stack" functionality
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2019

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 872 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c4ea20b643ff94f59be765cc0e961bc7c417376c

Sender Branch:

Branch Name: LPS-90252-review-767
Branch GIT ID: 888d70fa05ade45efa54ef2d581caf94cd256bb7

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2019

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

@drewbrokke


However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment.

ci:reopen


Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8
Job Results:

0 Tests Passed.
1 Test Failed.

  1. AXIS_VARIABLE=0,label_exp=!master #276570

    Please fix semantic versioning on drewbrokke/LPS-90252-review-767

         [exec] > Task :apps:portal:portal-weblogic-support:wrapSoyAlloyTemplate SKIPPED
         [exec] > Task :apps:portal:portal-weblogic-support:classes
         [exec] > Task :apps:portal:portal-weblogic-support:zipZippableResources UP-TO-DATE
         [exec] > Task :apps:portal:portal-output-stream-container:baseline
         [exec] > Task :apps:portal:portal-output-stream-container:syncVersions
         [exec] > Task :apps:portal:portal-weblogic-support:autoUpdateXml SKIPPED
         [exec] > Task :apps:portal:portal-weblogic-support:jar
         [exec] > Task :apps:portal:portal-output-stream-container-api:baseline
         [exec] > Task :apps:portal:portal-output-stream-container-api:syncVersions
         [exec] > Task :apps:portal:portal-upgrade-api:baseline
         [exec] > Task :apps:portal:portal-upgrade-api:syncVersions
         [exec] > Task :apps:portal:portal-instance-lifecycle-api:baseline
         [exec] > Task :apps:portal:portal-instance-lifecycle-api:syncVersions
         [exec] > Task :apps:portal:portal-cluster-multiple:autoUpdateXml SKIPPED
         [exec] > Task :apps:portal:portal-cluster-multiple:jar
         [exec] > Task :apps:portal:portal-cluster-multiple:baseline
         [exec] > Task :apps:portal:portal-cluster-multiple:syncVersions
         [exec] > Task :apps:portal:portal-monitoring:baseline
         [exec] > Task :apps:portal:portal-monitoring:syncVersions
         [exec] > Task :apps:portal:portal-executor:baseline
         [exec] > Task :apps:portal:portal-executor:syncVersions
         [exec] > Task :apps:portal:portal-pop-notifications:baseline
         [exec] > Task :apps:portal:portal-pop-notifications:syncVersions
         [exec] > Task :apps:portal:portal-weblogic-support:baseline
         [exec] > Task :apps:portal:portal-weblogic-support:syncVersions
         [exec] 272 actionable tasks: 239 executed, 33 up-to-date
         [exec] Gradle build finished at 2019-03-14 22:30:01.703.
         [exec] 
         [exec] FAILURE: Build failed with an exception.
         [exec] 
         [exec] * What went wrong:
         [exec] Execution failed for task ':apps:static:portal-configuration:portal-configuration-metatype-api:baseline'.
         [exec] > Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.portal.configuration.metatype.api-2.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.portal.configuration.metatype.api/1.1.8/8dc9119e2a5d69a9d2f3abd2bed01d59c07774b7/com.liferay.portal.configuration.metatype.api-1.1.8.jar

cc @
@brianchandotcom

This comment has been minimized.

Copy link
Owner

commented Mar 14, 2019

Merged. Thank you.
View total diff: 769d195...8abbadc

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2019

ci:test:relevant - 18 out of 21 jobs passed in 1 hour 33 minutes 56 seconds 44 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c4ea20b643ff94f59be765cc0e961bc7c417376c

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 80c7f7b31292e88a5853782af4dbf6eeccd5778d

18 out of 21 jobs PASSED
18 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #276570

      Please fix semantic versioning on drewbrokke/LPS-90252-review-767

           [exec] > Task :apps:portal:portal-weblogic-support:wrapSoyAlloyTemplate SKIPPED
           [exec] > Task :apps:portal:portal-weblogic-support:classes
           [exec] > Task :apps:portal:portal-weblogic-support:zipZippableResources UP-TO-DATE
           [exec] > Task :apps:portal:portal-output-stream-container:baseline
           [exec] > Task :apps:portal:portal-output-stream-container:syncVersions
           [exec] > Task :apps:portal:portal-weblogic-support:autoUpdateXml SKIPPED
           [exec] > Task :apps:portal:portal-weblogic-support:jar
           [exec] > Task :apps:portal:portal-output-stream-container-api:baseline
           [exec] > Task :apps:portal:portal-output-stream-container-api:syncVersions
           [exec] > Task :apps:portal:portal-upgrade-api:baseline
           [exec] > Task :apps:portal:portal-upgrade-api:syncVersions
           [exec] > Task :apps:portal:portal-instance-lifecycle-api:baseline
           [exec] > Task :apps:portal:portal-instance-lifecycle-api:syncVersions
           [exec] > Task :apps:portal:portal-cluster-multiple:autoUpdateXml SKIPPED
           [exec] > Task :apps:portal:portal-cluster-multiple:jar
           [exec] > Task :apps:portal:portal-cluster-multiple:baseline
           [exec] > Task :apps:portal:portal-cluster-multiple:syncVersions
           [exec] > Task :apps:portal:portal-monitoring:baseline
           [exec] > Task :apps:portal:portal-monitoring:syncVersions
           [exec] > Task :apps:portal:portal-executor:baseline
           [exec] > Task :apps:portal:portal-executor:syncVersions
           [exec] > Task :apps:portal:portal-pop-notifications:baseline
           [exec] > Task :apps:portal:portal-pop-notifications:syncVersions
           [exec] > Task :apps:portal:portal-weblogic-support:baseline
           [exec] > Task :apps:portal:portal-weblogic-support:syncVersions
           [exec] 272 actionable tasks: 239 executed, 33 up-to-date
           [exec] Gradle build finished at 2019-03-14 22:30:01.703.
           [exec] 
           [exec] FAILURE: Build failed with an exception.
           [exec] 
           [exec] * What went wrong:
           [exec] Execution failed for task ':apps:static:portal-configuration:portal-configuration-metatype-api:baseline'.
           [exec] > Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.portal.configuration.metatype.api-2.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.portal.configuration.metatype.api/1.1.8/8dc9119e2a5d69a9d2f3abd2bed01d59c07774b7/com.liferay.portal.configuration.metatype.api-1.1.8.jar

For upstream results, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.