Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-92344 Default User is displayed in User Administration Web #71939

Closed
wants to merge 3 commits into from
Closed

LPS-92344 Default User is displayed in User Administration Web #71939

wants to merge 3 commits into from

Conversation

pei-jung
Copy link

@drewbrokke @pei-jung
LPS-92344 users-admin-test - reproduces the bug with a test case
d7033da
@drewbrokke @pei-jung
LPS-92344 users-admin-impl - indexes and filters based on whether the…
57a8167 
… user is the default user. Searches should never contain the default user. Instead the default user should be gotten through the explicit methods on the user service.
@drewbrokke @pei-jung
LPS-92344 users-admin-test - updates expected fields for other tests
3b4fd64
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@pei-jung pei-jung mentioned this pull request Apr 19, 2019
Closed
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 9 seconds 947 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2727d4271225c4b71b31ca7e6e6c60248e9de0d7

Sender Branch:

Branch Name: pull-request-417-LPS-92344
Branch GIT ID: 3b4fd64caff7b50981f2e72e1ebc3351d76b37ce

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 20 out of 24 jobs passed in 1 hour 21 minutes 56 seconds 2 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2727d4271225c4b71b31ca7e6e6c60248e9de0d7

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 77551e8ed10b3c7c9c66df3ff36895fe76dcfee5

20 out of 24 jobs PASSED
20 Successful Jobs:
For more details click here.

Failures unique to this pull:

Failures in common with acceptance upstream results at 48cd71b:
  2. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #46733

      Please fix semantic versioning on pei-jung/pull-request-417-LPS-92344

           [exec] = ================================================== ========== ========== ========== ========== ==========
     [exec] * com.liferay.asset.kernel.service                   MINOR      1.9.0      1.9.0      1.10.0     VERSION INCREASE REQUIRED
     [exec] 	<   class      com.liferay.asset.kernel.service.AssetEntryLocalServiceUtil
     [exec] 		+   method     search(long,long[],long,long[],long,java.lang.String,boolean,int[],int,int,com.liferay.portal.kernel.search.Sort)
     [exec] 			+   access     static
     [exec] 			+   return     com.liferay.portal.kernel.search.Hits
     [exec] 		+   method     searchCount(long,long[],long,long[],long,java.lang.String,boolean,int[])
     [exec] 			+   access     static
     [exec] 			+   return     long
     [exec] 	<   class      com.liferay.asset.kernel.service.AssetEntryLocalServiceWrapper
     [exec] 		+   method     search(long,long[],long,long[],long,java.lang.String,boolean,int[],int,int,com.liferay.portal.kernel.search.Sort)
     [exec] 			+   return     com.liferay.portal.kernel.search.Hits
     [exec] 		+   method     searchCount(long,long[],long,long[],long,java.lang.String,boolean,int[])
     [exec] 			+   return     long
     [exec] 	<   interface  com.liferay.asset.kernel.service.AssetEntryLocalService
     [exec] 		+   method     search(long,long[],long,long[],long,java.lang.String,boolean,int[],int,int,com.liferay.portal.kernel.search.Sort)
     [exec] 			+   access     abstract
     [exec] 			+   annotated  com.liferay.portal.kernel.transaction.Transactional
     [exec] 				+   property   propagation='SUPPORTS'
     [exec] 				+   property   readOnly=true
     [exec] 			+   return     com.liferay.portal.kernel.search.Hits
     [exec] 		+   method     searchCount(long,long[],long,long[],long,java.lang.String,boolean,int[])
     [exec] 			+   access     abstract
     [exec] 			+   annotated  com.liferay.portal.kernel.transaction.Transactional
     [exec] 				+   property   propagation='SUPPORTS'
     [exec] 				+   property   readOnly=true
     [exec] 			+   return     long
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/3.62.0/6d4d1e1934e9b87b089f7f526edecf9743ad23ff/com.liferay.portal.kernel-3.62.0.jar

@brianchandotcom
Copy link
Owner

Merged. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
4 participants
@pei-jung @liferay-continuous-integration @brianchandotcom @drewbrokke