Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lps 94399 #72206

Closed
wants to merge 36 commits into from

Conversation

Projects
None yet
4 participants
@shuyangzhou
Copy link

commented Apr 24, 2019

No description provided.

Preston-Crary added some commits Apr 18, 2019

LPS-94399 Pull up logic. Remove tautology test, after this it was ass…
…erting converting a string to a byte array and back.
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@brianchandotcom

This comment has been minimized.

Copy link
Owner

commented Apr 24, 2019

Merged. Thank you.
View total diff: bd43d27...8fa8093

LPS-94399 Mute the confusing the System.err print. Change this to log…
… capturing once migrate to arquillian bridge test.
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 24 seconds 563 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bd43d276ab52f547509ffa82fb95b81a075511e1

Sender Branch:

Branch Name: LPS-94399
Branch GIT ID: 44f90dbd3eadfe520db768be345744273b9e1dd5

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

ci:test:relevant - 19 out of 22 jobs passed in 1 hour 1 minute 14 seconds 371 ms

Click here for more details.

Base Branch:

Branch Name: master

Copied in Private Modules Branch:

Branch Name:

19 out of 22 jobs PASSED
19 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8
    Job Results:

    6 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #250451
      1. ModulesStructureTest.testScanGradleFiles
        junit.framework.AssertionFailedError: Incorrect configuration of dependency {compileOnly project(":apps:asset:asset-display-page-api")} in modules/apps/layout/layout-type-controller/layout-type-controller-test/build.gradle, use one of these instead: "testIntegrationCompile", "testIntegrationRuntime"
        	at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1356)
        	at com.liferay.portal.modules.ModulesStructureTest.access$700(ModulesStructureTest.java:66)
        	at com.liferay.portal.modules.ModulesStructureTest$3.visitFile(ModulesStructureTest.java:338)
        	at com.liferay.portal.modules.ModulesStructureTest$3.visitFile(ModulesStructureTest.java:313)
        	at java.nio.file.Files.walkFileTree(Files.java:2670)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:311)
        

For upstream results, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.