Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-91754 #72920

Closed
wants to merge 1 commit into from

Conversation

@adolfopa
Copy link

commented May 9, 2019

Hey @brianchandotcom,

I've added a message to the commit explaining the reasons behind this change.

Thanks!

LPS-91754 copy file instead move on checking
This change is needed because of the way the NTFS filesystem works.  When
multiple processes open a file, NTFS creates an implicit shared lock to prevent
any process from deleting the file until all consumers release it.

This affects D&M when doing a combined update and checkin operation.  The update
operation will spawn a bunch of background OS processes (to extract metadata,
generate previews, etc.), and immediately after that it will perform the
checkin.

Part of the checkin operation involves the deletion of the PWC (precisely the
code that we're changing).  As the background processes haven't finished with
the processing yet (it usually takes more time than the checkin) this operation
fails, as those processes are working with the PWC.

Keeping the PWC around has no user visible effects, other than consuming a bit
more of disk space.
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 22 seconds 184 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 45263ac96b7aace681ac93071f409c733716b23e

Sender Branch:

Branch Name: LPS-91754
Branch GIT ID: 5870a0012d1089c4e1c083fb6fa645559d61306c

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

ci:test:relevant - 79 out of 90 jobs passed in 1 hour 33 minutes 54 seconds 486 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c235139e6ee161e2e2fbb671da5d0755fed44c1d

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 170d65bf0c76fe1774f2652a47ab584ab42f292c

79 out of 90 jobs PASSED

11 Failed Jobs:

79 Successful Jobs:
For more details click here.

Failures unique to this pull:


Failures in common with acceptance upstream results at 035db89:
  1. ...
@brianchandotcom

This comment has been minimized.

Copy link
Owner

commented May 9, 2019

Merged. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.