Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-95415 Keeping the same protocol in redirects #73118

Closed
wants to merge 1 commit into from
Closed

LPS-95415 Keeping the same protocol in redirects #73118

wants to merge 1 commit into from

Conversation

4lejandrito
Copy link

No description provided.

@4lejandrito
LPS-95415 Keeping the same protocol in redirects
bc76de5 
When using an external server that receives HTTPS but connects to
Liferay via HTTP the getCurrentCompleteURL returns an http URL regardless of the preferred
protocol configured in web.server.protocol property (see
https://community.liferay.com/en_GB/forums/-/message_boards/message/5662674).

getCurrentURL returns a relative URL which will use the right protocol.
Since these are internal redirects it is safe to use a relative URL.

This issue could be also solved externally by forcing redirection of all http URLs to HTTPS in the web server.
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 46 seconds 288 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e622fbb7dd8cca0548a1afd8de7146666af6f4a0

Sender Branch:

Branch Name: LPS-95415
Branch GIT ID: bc76de525bfe2ffc7422c1fc4136833a0de705fa

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@brianchandotcom
Copy link
Owner

Merged. Thx.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 25 out of 28 jobs passed in 1 hour 9 minutes 49 seconds 551 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e622fbb7dd8cca0548a1afd8de7146666af6f4a0

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: da67ed2286f3e7529b7c658abd1554cb1974ace3

25 out of 28 jobs PASSED
25 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at e622fbb:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
    Job Results:

    900 Tests Passed.
    15 Tests Failed.

    1. AXIS_VARIABLE=3,label_exp=!master #302995
      1. BlogPostingImageResourceTest.classMethod
        java.lang.NullPointerException
	at com.liferay.arquillian.extension.junit.bridge.client.SocketState.writeUTF(SocketState.java:113)
	at com.liferay.arquillian.extension.junit.bridge.client.ClientState$1.execute(ClientState.java:123)
	at com.liferay.arquillian.extension.junit.bridge.junit.Arquillian.run(Arquillian.java:122)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:106)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
	at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:66)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
	at org....
      2. BlogPostingResourceTest.classMethod
        java.lang.NullPointerException
	at com.liferay.arquillian.extension.junit.bridge.client.SocketState.writeUTF(SocketState.java:113)
	at com.liferay.arquillian.extension.junit.bridge.client.ClientState$1.execute(ClientState.java:123)
	at com.liferay.arquillian.extension.junit.bridge.junit.Arquillian.run(Arquillian.java:122)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:106)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
	at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:66)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
	at org....
      3. CommentResourceTest.classMethod
        java.io.IOException: Start of bundle with id 1018 failed with message: Could not resolve module: com.liferay.headless.delivery.test [1018]
  Unresolved requirement: Import-Package: com.liferay.headless.delivery.client.dto.v1_0

        at org.apache.aries.jmx.framework.Framework.startBundle(Framework.java:461)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:275)
at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
at com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
at javax.management.StandardMBean.invoke(StandardMBean.java:405)
at com....</code></pre></div></li><li>...</li></ol></div></li></ol></div></li><li><div><h5><a href="https://test-1-4.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/296462/">test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8</a></h5><div><h6>Job Results:</h6><p>214 Tests Passed.<br/>1 Test Failed.</p></div><ol><li><div><a href="https://test-1-4.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/296462//consoleText">AXIS_VARIABLE=0,label_exp=!master #296462</a><ol><li><div><a href="https://test-1-4.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/296462//testReport/com.liferay.project.templates/ProjectTemplatesTest/testCompareGradlePluginVersions">ProjectTemplatesTest.testCompareGradlePluginVersions</a><pre><code>org.junit.ComparisonFailure: com.liferay.plugin versions do not match expected:&lt;3.13.19[5]&gt; but was:&lt;3.13.19[6]&gt;
at org.junit.Assert.assertEquals(Assert.java:115)
at com.liferay.project.templates.ProjectTemplatesTest.testCompareGradlePluginVersions(ProjectTemplatesTest.java:4068)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at o...</code></pre></div></li></ol></div></li></ol></div></li></ol></details></details></html>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
3 participants
@4lejandrito @liferay-continuous-integration @brianchandotcom