Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-97876 Update liferay-npm-scripts to v4.5.0 #75404

Conversation

@wincent
Copy link

commented Jul 8, 2019

Changes since v4.4.0:

  • Silences 8 spurious ESLint warnings about "File ignored default".
  • Fixes problem with globs not matching files on Windows.
  • Automatic copyright header enforcement will now work when run from project folders (modules/apps/*/*).
  • The @babel/preset-react package is now bundled, which means we can delete it from out top-level package.json.
  • Fixed grammar in one user-visible message.

Ran formatting over a bunch of files which had changed in 3e65131; checked with @p2kmgcl why the changes went in in that commit and it seems like some kind of stale state - we verified that yarn format from both top-level and project folder work as expected, as does gradlew formatSource -a in the project. As only the ends of the files are touched in this commit, we don't expect and merge or rebase conflicts.

LPS-97876 Update liferay-npm-scripts to v4.5.0
Changes since v4.4.0:

- Silences 8 spurious ESLint warnings about "File ignored default".
- Fixes problem with globs not matching files on Windows.
- Automatic copyright header enforcement will now work when run from
  project folders (`modules/apps/*/*`).
- The `@babel/preset-react` package is now bundled, which means we can
  delete it from out top-level package.json.
- Fixed grammar in one user-visible message.

Ran formatting over a bunch of files which had changed in 3e65131;
checked with p2kmgcl why the changes went in in that commit and it seems
like some kind of stale state - we verified that `yarn format` from both
top-level and project folder work as expected, as does `gradlew
formatSource -a` in the project.
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 10 seconds 462 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c8ea5897859a139f530fbe634f358761760f76db

Sender Branch:

Branch Name: wincent/LPS-97876/liferay-npm-scripts
Branch GIT ID: 97a3a4d5403c779d626c0d6810c93d9b5a5d1e05

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

ci:test:relevant - 23 out of 27 jobs passed in 1 hour 21 minutes 45 seconds 449 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c8ea5897859a139f530fbe634f358761760f76db

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 36a75fcae966182acf9988b97dd8069d75fa8b01

23 out of 27 jobs PASSED
23 Successful Jobs:
For more details click here.

Failures unique to this pull:


Failures in common with acceptance upstream results at c8ea589:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
    Job Results:

    389 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #324694
      1. LayoutStagedModelDataHandlerTest.testCleanStagedModelDataHandler
        java.lang.AssertionError: com.liferay.portal.xml.NodeList@75483b6b expected:<2> but was:<1>
        	at org.junit.Assert.fail(Assert.java:88)
        	at org.junit.Assert.failNotEquals(Assert.java:834)
        	at org.junit.Assert.assertEquals(Assert.java:645)
        	at com.liferay.exportimport.test.util.lar.BaseStagedModelDataHandlerTestCase.validateExport(BaseStagedModelDataHandlerTestCase.java:1020)
        	at com.liferay.exportimport.test.util.lar.BaseStagedModelDataHandlerTestCase.testCleanStagedModelDataHandler(BaseStagedModelDataHandlerTestCase.java:229)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$2.evaluate(TestExecutorRunnable.java:218)
        	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
        	at com.liferay.por...
      2. LayoutStagedModelDataHandlerTest.testStagedModelDataHandler
        java.lang.AssertionError: com.liferay.portal.xml.NodeList@370de400 expected:<2> but was:<1>
        	at org.junit.Assert.fail(Assert.java:88)
        	at org.junit.Assert.failNotEquals(Assert.java:834)
        	at org.junit.Assert.assertEquals(Assert.java:645)
        	at com.liferay.exportimport.test.util.lar.BaseStagedModelDataHandlerTestCase.validateExport(BaseStagedModelDataHandlerTestCase.java:1020)
        	at com.liferay.exportimport.test.util.lar.BaseStagedModelDataHandlerTestCase.testStagedModelDataHandler(BaseStagedModelDataHandlerTestCase.java:400)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$2.evaluate(TestExecutorRunnable.java:218)
        	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
        	at com.liferay.portal.k...
  2. test-portal-acceptance-pullrequest-batch(master)/unit-jdk8
    Job Results:

    2723 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #286434
      1. HypersonicSQLTransformerLogicTest.testReplaceNullDate
        junit.framework.AssertionFailedError: expected:<select [NULL] from Foo> but was:<select [CAST(NULL AS DATE)] from Foo>
        	at com.liferay.portal.dao.sql.transformer.BaseSQLTransformerLogicTestCase.testReplaceNullDate(BaseSQLTransformerLogicTestCase.java:135)
        
@brianchandotcom

This comment has been minimized.

Copy link
Owner

commented Jul 8, 2019

Very nice @wincent

fyi @hhuijser

@wincent wincent deleted the wincent:wincent/LPS-97876/liferay-npm-scripts branch Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.