Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-96762 Add MVCCVersion to DL Objects #75564

Closed
wants to merge 7 commits into from
Closed

LPS-96762 Add MVCCVersion to DL Objects #75564

wants to merge 7 commits into from

Conversation

achaparro
Copy link

@achaparro achaparro commented Jul 10, 2019 •
edited

@achaparro achaparro mentioned this pull request Jul 10, 2019
Closed
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@achaparro achaparro changed the title LPS-96762 Execute the whole upgrade for both cases LPS-96762 Add MVCCVerion to DL Objects Jul 10, 2019
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 55 seconds 219 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f559e7e7e3605e1e11ab35e28196fdc77be48dba

Sender Branch:

Branch Name: pr-333
Branch GIT ID: 8c5317d2cde93e47716b2766790a3a0c5be8e58e

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 0 out of 1 jobs passed in 2 hours 13 minutes 29 seconds 741 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 45145eff8a1526b98b88cb3c01c0ef7b0450aaf7

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8aa8225ed15f83a47db04881c98b101d9cf07baf

0 out of 1 jobs PASSED
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    0 Jobs Passed.
    1 Job Failed.

    A CI failure has occurred. QA Engineering has been notified. Please try again later or contact QA Engineering for an update.

For upstream results, click here.

@achaparro
Copy link
Author

ci:test:relevant

@achaparro achaparro changed the title LPS-96762 Add MVCCVerion to DL Objects LPS-96762 Add MVCCVersion to DL Objects Jul 11, 2019
@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 89 out of 101 jobs passed in 1 hour 45 minutes 41 seconds 634 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a46ce2cffa99022a9f6ee0e96480e2cac6f28a6e

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: e0630253a3e6d5f70c565e70031b93ef3254a8bb

89 out of 101 jobs PASSED

12 Failed Jobs:

89 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/18
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #259081
           [exec] | | | | | | | | | | |____4111
     [exec] | | | | | | | | | | | |____functional-tomcat90-mysql57-jdk8
     [exec] | | | | | | | | | | | | |____18
     [exec] | | | | | | | | | | | | | |____0
     [exec] | | | | | | | | | | | | | | |____jenkins-console.txt.gz
   [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20190711023521694
     [echo] Warning: Unable to locate '/opt/dev/projects/github/liferay-jenkins-ee/testray/dependencies/test.generated.properties'.
[beanshell] Warning: LocalFile.FormRules#ConfigureCalculateRule is not contained within the list of compiled test case names
     [echo] Build testray result: /opt/dev/projects/github/liferay-jenkins-ee/testray/suite/TESTS-test-1-7_test-portal-acceptance-pullrequest(master)_4111_functional-tomcat90-mysql57-jdk8_18_0.xml
     [echo] send.to.testray.logs.start.timestamp: 07-10-2019 19:35:21:909 PDT
     [echo] Sending Testray logs to Testray production server.
   [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20190711023521912
[stopwatch] [send.to.testray.logs: 0.219 sec]
     [echo] send.to.testray.results.start.timestamp: 07-10-2019 19:35:22:130 PDT
     [echo] Sending Testray results to Testray production server.
   [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20190711023522133
[stopwatch] [send.to.testray.results: 0.150 sec]
[stopwatch] [record.testray.results.TESTS-test-1-7_test-portal-acceptance-pullrequest(master)_4111_functional-tomcat90-mysql57-jdk8_18_0.xml: 5.492 sec]
[stopwatch] [record.testray.results: 5.588 sec]

      BUILD FAILED
      
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:10864: The following error occurred while executing this line:
      
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common-portal-acceptance-batch.xml:181: The following error occurred while executing this line:
      
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:8282: Sourced file: inline evaluation of: 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : TargetError : at Line: 107 : in file: inline evaluation of: 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : throw e ;
      

      Target exception: java.lang.RuntimeException: Unable to create local branch 7.0.x at 3b3953a6a932f4a5a5c0dbb5e7c9815035dd3175
      
fatal: cannot lock ref 'refs/heads/7.0.x': unable to resolve reference 'refs/heads/7.0.x': reference broken
  5. test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #63390
           [exec] * What went wrong:
      
[exec] Execution failed for task ':private:apps:portal-workflow:portal-workflow-metrics-web:npmRunTest'.
      
[exec] > java.io.IOException: Process '[/opt/dev/projects/github/liferay-portal/build/node/bin/node, /opt/dev/projects/github/liferay-portal/modules/yarn-1.13.0.js, --production, false, --registry, http://mirrors.lax.liferay.com:4873, run, test]' finished with non-zero exit value 1
      
[exec]
      
[exec] * Try:
      
[exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
      
[exec]
      
[exec] * Exception is:
      
[exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':private:apps:portal-workflow:portal-workflow-metrics-web:npmRunTest'.
      
[exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:110)
      
[exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)
      
[exec] 	at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
      
[exec] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
      
[exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
      
[exec] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
      
[exec] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
      
[exec] 	at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)
      
[exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
      
[exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)
      
[exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:59)
      
[exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

@brianchandotcom
Copy link
Owner

@achaparro Can you resend on top of achaparro#335

I made some changes, but I found UpgradeMVCCVersionTest very weird.

		DBAssertionUtil.assertColumns(
			UpgradeMVCCVersionTestModuleTable.TABLE_NAME, "_id", "_userId",
			"mvccVersion");

vs.

		DBAssertionUtil.assertColumns(
			UpgradeMVCCVersionTestPortalTable.TABLE_NAME, "_id", "_userId",
			"mvccversion");

Is the difference in case on purpose?

I also re-read the test over and over again but could not figure out what it was doing? I mean, how is it testing module vs. portal upgrades?

Please resend. Thx

@brianchandotcom brianchandotcom mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
4 participants
@achaparro @liferay-continuous-integration @brianchandotcom @AliciaGarciaGarcia