Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-98053 Fix use a regular function instead of arrow function in not transpiled code #75823

Closed
wants to merge 1 commit into from

Conversation

@jbalsas
Copy link

jbalsas commented Jul 17, 2019

No description provided.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Jul 17, 2019

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Jul 17, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 11 seconds 15 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 826a5b06994aa6d1cd2f0afc79023ad7e44f627b

Sender Branch:

Branch Name: pr-1822
Branch GIT ID: 8c33b62aadd31fc98beac82f0ebcc36cbb8ec33a

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.
@jpince

This comment has been minimized.

Copy link

jpince commented Jul 17, 2019

ci:test:bundle @john-co

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Jul 17, 2019

ci:test:relevant - 25 out of 28 jobs passed in 1 hour 47 minutes 49 seconds 800 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 826a5b06994aa6d1cd2f0afc79023ad7e44f627b

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: b186f390382e554f5ada1a667c464f572587fabb

25 out of 28 jobs PASSED
25 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 826a5b0:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
    Job Results:

    1157 Tests Passed.
    92 Tests Failed.

    1. AXIS_VARIABLE=1,label_exp=!master #64571
      1. FileEntryStagedModelDataHandlerTest.testExportsTheVersionAfterDeletingOnStaging
        com.liferay.exportimport.kernel.lar.PortletDataException: com.liferay.portal.kernel.dao.orm.ORMException: {"classNameId":"0","classPK":"0","companyId":"20102","createDate":1563375597649,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"txt","extraSettings":"","fileEntryId":"50912","fileEntryTypeId":"50877","fileName":"S88a8ojz.txt","folderId":"50908","groupId":"50865","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563375598452,"mvccVersion":"2","name":"599","readCount":0,"repositoryId":"50865","size":"8","smallImageId":"0","title":"S88a8ojz","treePath":"\/50908\/","userId":"20131","userName":"Test Test","uuid":"c4f692ba-a3e1-baaa-94ee-44d3acf73bd2","version":"1.1"} is stale in comparison to {"classNameId":"0","classPK":"0","companyId":"20102","createDate":1563375597649,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"txt","extraSettings":"","fileEntryId":"50912","fileEntryTypeId":"50877","fileName":"S88a8ojz.txt","folderId":"50908","groupId":"50865","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563375598452,"mvccVersion":"3","name":"599","readCount":0,"repositoryId":"50865","size":"8","smallImageId":"0","title":"S88a8ojz","treePath":"\/50908\/","userId":"20131","userName":"Test Test","uuid":"c4f692ba-a3e1-baaa-94ee-44d3acf73bd2","version":"1.3"}
        	at com.liferay.exportimport.kernel.lar.BaseStagedMod...
      2. FolderStagedModelDataHandlerTest.testCleanAssetCategoriesAndTags
        com.liferay.exportimport.kernel.lar.PortletDataException: com.liferay.portal.kernel.dao.orm.ORMException: {"companyId":"20102","createDate":1563375579771,"defaultFileEntryTypeId":"50025","description":"6dpnefOZ","folderId":"50032","groupId":"49988","hidden":false,"lastPostDate":1563375580582,"lastPublishDate":null,"modifiedDate":1563375579816,"mountPoint":false,"mvccVersion":"1","name":"R6LFZx4e","parentFolderId":"50017","repositoryId":"49988","restrictionType":1,"status":0,"statusByUserId":"0","statusByUserName":"","statusDate":null,"treePath":"\/50017\/50032\/","userId":"20131","userName":"Test Test","uuid":"5d9fb4cc-6e54-fcda-83f9-9b92ed394063"} is stale in comparison to {"companyId":"20102","createDate":1563375579771,"defaultFileEntryTypeId":"0","description":"6dpnefOZ","folderId":"50032","groupId":"49988","hidden":false,"lastPostDate":1563375580582,"lastPublishDate":null,"modifiedDate":1563375579816,"mountPoint":false,"mvccVersion":"2","name":"R6LFZx4e","parentFolderId":"50017","repositoryId":"49988","restrictionType":0,"status":0,"statusByUserId":"0","statusByUserName":"","statusDate":null,"treePath":"\/50017\/50032\/","userId":"20131","userName":"Test Test","uuid":"5d9fb4cc-6e54-fcda-83f9-9b92ed394063"}
        	at com.liferay.exportimport.kernel.lar.BaseStagedModelDataHandler.importStagedModel(BaseStagedModelDataHandler.java:433)
        	at com.liferay.exportimport.kernel.lar.StagedModelDataHandlerUtil.importStagedModel(StagedModelDataHandlerUtil.java:456)
        	at com.liferay.exporti...
      3. DLFileEntryFinderTest.testCountByExtraSettings
        com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: {"classNameId":"0","classPK":"0","companyId":"20102","createDate":1563375439121,"custom1ImageId":"0","custom2ImageId":"0","description":"FE3.txt","extension":"txt","extraSettings":"","fileEntryId":"42544","fileEntryTypeId":"0","fileName":"FE3.txt","folderId":"42515","groupId":"42510","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563375439363,"mvccVersion":"1","name":"320","readCount":0,"repositoryId":"42510","size":"8","smallImageId":"0","title":"FE3.txt","treePath":"\/42515\/","userId":"20131","userName":"Test Test","uuid":"a8208052-1005-ee25-2966-4210a14ac822","version":"1.1"} is stale in comparison to {"classNameId":"0","classPK":"0","companyId":"20102","createDate":1563375439121,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"txt","extraSettings":"","fileEntryId":"42544","fileEntryTypeId":"0","fileName":"FE3.txt","folderId":"42515","groupId":"42510","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563375439221,"mvccVersion":"2","name":"320","readCount":0,"repositoryId":"42510","size":"8","smallImageId":"0","title":"FE3.txt","treePath":"\/42515\/","userId":"20131","userName":"Test Test","uuid":"a8208052-1005-ee25-2966-4210a14ac822","version":"1.1"}
        	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceI...
      4. ...
    2. AXIS_VARIABLE=2,label_exp=!master #64571
      1. DLFileEntryTrashHandlerTest.testTrashAndRestoreWithDraftStatus
        com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: {"classNameId":"0","classPK":"0","companyId":"20102","createDate":1563375291621,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"txt","extraSettings":"","fileEntryId":"48600","fileEntryTypeId":"0","fileName":"UJehlC8IcEBo6OHD5QQFGQqEFwbLmjhqFRo7Xcn7usUEilpYqVtmuYTaupVC8RFYoJ6FCI2lydUUdUevBwp0K9QhZ0LnafXi3XQCZ5XIZDR7AWAczAIYShICgxkDjhSci6OR32Dpb4Xd4aq5EJxI24kUco3vYVzJAFmMQHAvt4Ji65xBrHCfol3UpOYN9BZ7DJrplUpmXfSegfP05Pd8Uohz3Plgn61xRS6SYiu4vCNYISbC68wGP9jWMxd.txt","folderId":"48596","groupId":"48593","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563375291712,"mvccVersion":"1","name":"229","readCount":0,"repositoryId":"48593","size":"8","smallImageId":"0","title":"UJehlC8IcEBo6OHD5QQFGQqEFwbLmjhqFRo7Xcn7usUEilpYqVtmuYTaupVC8RFYoJ6FCI2lydUUdUevBwp0K9QhZ0LnafXi3XQCZ5XIZDR7AWAczAIYShICgxkDjhSci6OR32Dpb4Xd4aq5EJxI24kUco3vYVzJAFmMQHAvt4Ji65xBrHCfol3UpOYN9BZ7DJrplUpmXfSegfP05Pd8Uohz3Plgn61xRS6SYiu4vCNYISbC68wGP9jWMxdEuoV","treePath":"\/48596\/","userId":"20131","userName":"Test Test","uuid":"323258da-7742-55eb-acfc-9491ca893697","version":"1.0"} is stale in comparison to {"classNameId":"0","classPK":"0","companyId":"20102","createDate":1563375291621,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"txt","extraSettings":"","fileEntryId":"48600","fileEntryTypeId":"0","fileNam...
      2. DLFileEntryTrashHandlerTest.testTrashAndRestoreWithDraftStatusIndexable
        com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: {"classNameId":"0","classPK":"0","companyId":"20102","createDate":1563375292553,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"txt","extraSettings":"","fileEntryId":"48628","fileEntryTypeId":"0","fileName":"UJehlC8IcEBo6OHD5QQFGQqEFwbLmjhqFRo7Xcn7usUEilpYqVtmuYTaupVC8RFYoJ6FCI2lydUUdUevBwp0K9QhZ0LnafXi3XQCZ5XIZDR7AWAczAIYShICgxkDjhSci6OR32Dpb4Xd4aq5EJxI24kUco3vYVzJAFmMQHAvt4Ji65xBrHCfol3UpOYN9BZ7DJrplUpmXfSegfP05Pd8Uohz3Plgn61xRS6SYiu4vCNYISbC68wGP9jWMxd.txt","folderId":"48624","groupId":"48621","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563375292637,"mvccVersion":"1","name":"230","readCount":0,"repositoryId":"48621","size":"8","smallImageId":"0","title":"UJehlC8IcEBo6OHD5QQFGQqEFwbLmjhqFRo7Xcn7usUEilpYqVtmuYTaupVC8RFYoJ6FCI2lydUUdUevBwp0K9QhZ0LnafXi3XQCZ5XIZDR7AWAczAIYShICgxkDjhSci6OR32Dpb4Xd4aq5EJxI24kUco3vYVzJAFmMQHAvt4Ji65xBrHCfol3UpOYN9BZ7DJrplUpmXfSegfP05Pd8Uohz3Plgn61xRS6SYiu4vCNYISbC68wGP9jWMxdEuoV","treePath":"\/48624\/","userId":"20131","userName":"Test Test","uuid":"e5a34f43-c13a-f558-c3c8-62d6bf50d136","version":"1.0"} is stale in comparison to {"classNameId":"0","classPK":"0","companyId":"20102","createDate":1563375292553,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"txt","extraSettings":"","fileEntryId":"48628","fileEntryTypeId":"0","fileNam...
      3. DLFileEntryTrashHandlerTest.testTrashAndRestoreWithDraftStatusIsNotVisible
        com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: {"classNameId":"0","classPK":"0","companyId":"20102","createDate":1563375292874,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"txt","extraSettings":"","fileEntryId":"48656","fileEntryTypeId":"0","fileName":"UJehlC8IcEBo6OHD5QQFGQqEFwbLmjhqFRo7Xcn7usUEilpYqVtmuYTaupVC8RFYoJ6FCI2lydUUdUevBwp0K9QhZ0LnafXi3XQCZ5XIZDR7AWAczAIYShICgxkDjhSci6OR32Dpb4Xd4aq5EJxI24kUco3vYVzJAFmMQHAvt4Ji65xBrHCfol3UpOYN9BZ7DJrplUpmXfSegfP05Pd8Uohz3Plgn61xRS6SYiu4vCNYISbC68wGP9jWMxd.txt","folderId":"48652","groupId":"48649","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563375292953,"mvccVersion":"1","name":"231","readCount":0,"repositoryId":"48649","size":"8","smallImageId":"0","title":"UJehlC8IcEBo6OHD5QQFGQqEFwbLmjhqFRo7Xcn7usUEilpYqVtmuYTaupVC8RFYoJ6FCI2lydUUdUevBwp0K9QhZ0LnafXi3XQCZ5XIZDR7AWAczAIYShICgxkDjhSci6OR32Dpb4Xd4aq5EJxI24kUco3vYVzJAFmMQHAvt4Ji65xBrHCfol3UpOYN9BZ7DJrplUpmXfSegfP05Pd8Uohz3Plgn61xRS6SYiu4vCNYISbC68wGP9jWMxdEuoV","treePath":"\/48652\/","userId":"20131","userName":"Test Test","uuid":"d0572b95-b4f0-93cb-1211-b9f9a2423ba5","version":"1.0"} is stale in comparison to {"classNameId":"0","classPK":"0","companyId":"20102","createDate":1563375292874,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"txt","extraSettings":"","fileEntryId":"48656","fileEntryTypeId":"0","fileNam...
      4. ...
    3. AXIS_VARIABLE=3,label_exp=!master #64571
      1. RepositoryModelUtilTest.testToFileVersions
        com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: {"classNameId":"0","classPK":"0","companyId":"20102","createDate":1563375381195,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"","extraSettings":"","fileEntryId":"48273","fileEntryTypeId":"0","fileName":"ca2pCXk5","folderId":"48269","groupId":"48266","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563375381222,"mvccVersion":"0","name":"130","readCount":0,"repositoryId":"48266","size":"8","smallImageId":"0","title":"Gxtu99MB","treePath":"\/48269\/","userId":"20131","userName":"Test Test","uuid":"e3fde7d1-0bd6-56c6-a072-d48ee00066d7","version":"1.0"} is stale in comparison to {"classNameId":"0","classPK":"0","companyId":"20102","createDate":1563375381195,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"","extraSettings":"","fileEntryId":"48273","fileEntryTypeId":"0","fileName":"ca2pCXk5","folderId":"48269","groupId":"48266","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563375381222,"mvccVersion":"1","name":"130","readCount":0,"repositoryId":"48266","size":"8","smallImageId":"0","title":"gw150u3Z","treePath":"\/48269\/","userId":"20131","userName":"Test Test","uuid":"e3fde7d1-0bd6-56c6-a072-d48ee00066d7","version":"1.0"}
        	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.proce...
  2. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #311327

      Please fix semantic versioning on jbalsas/pr-1822

          [javac] Note: Recompile with -Xlint:unchecked for details.
      

      init-jar:

      jar:
      [copy] Copying 1 file to /opt/dev/projects/github/liferay-portal/portal-kernel/classes/META-INF/maven/com.liferay.portal/com.liferay.portal.kernel
      [propertyfile] Creating new property file: /opt/dev/projects/github/liferay-portal/portal-kernel/classes/META-INF/maven/com.liferay.portal/com.liferay.portal.kernel/pom.properties
      [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1929569350.properties

      download-latest-artifact:

      init-compile:

      compile:
      [delete] Deleting: /opt/dev/projects/github/liferay-portal/null39685286.properties

      download-latest-artifact:

      init-compile:

      compile:
      [copy] Copying 22 files to /opt/dev/projects/github/liferay-portal/util-java/classes
      [javac] Compiling 103 source files to /opt/dev/projects/github/liferay-portal/util-java/classes
      [javac] Note: /opt/dev/projects/github/liferay-portal/util-java/src/com/liferay/util/servlet/NullSession.java uses or overrides a deprecated API.
      [javac] Note: Recompile with -Xlint:deprecation for details.
      [javac] Note: Some input files use unchecked or unsafe operations.
      [javac] Note: Recompile with -Xlint:unchecked for details.
      [sync-dir] Synchronizing /opt/dev/projects/github/liferay-binaries-cache-2017/.gradle/caches/modules-2/files-2.1 into /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1
      [sync-dir] 0 files synchronized in 423ms
      [exec] Using proxy squid.lax.liferay.com:3128.
      [exec] > Task :classes UP-TO-DATE
      [exec] > Task :jar SKIPPED
      [exec]
      [exec] > Task :baseline4
      [exec] PACKAGE_NAME DELTA CUR_VER BASE_VER REC_VER WARNINGS
      [exec] = ================================================== ========== ========== ========== ========== ==========
      [exec] com.liferay.exportimport.kernel.configuration UNCHANGED 2.1.1 2.1.0 2.1.0 EXCESSIVE VERSION INCREASE
      [exec] - version 2.1.0
      [exec] + version 2.1.1
      [exec] [Baseline Report] Mode: diff (persisted)
      [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/4.22.0/71d2c10d40b6c32c1d9c1a99d9bb4cab58dba477/com.liferay.portal.kernel-4.22.0.jar

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Jul 17, 2019

✔️ ci:test:bundle - 1 out of 1 jobs passed in 52 minutes 1 second 426 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 826a5b06994aa6d1cd2f0afc79023ad7e44f627b

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: b186f390382e554f5ada1a667c464f572587fabb

1 out of 1 jobs PASSED
For more details click here.
Test bundle downloads:
@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Jul 17, 2019

Merged. Thank you.
View total diff: 11e73d2...db2bbf2

@jbalsas jbalsas deleted the jbalsas:pr-1822 branch Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.