Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-99625 Change operation to change the experiment status to POST and use a JSON body #76900

Closed
wants to merge 3 commits into from

Conversation

@dgarciasarai
Copy link

dgarciasarai commented Aug 13, 2019

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Aug 13, 2019

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Aug 13, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 52 seconds 357 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 27800770b780195b90da7e420bd1ee6e67e3f095

Sender Branch:

Branch Name: LPS-99625
Branch GIT ID: b7b11b44d6da417e475f9ea8116f4094d242bc39

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Aug 13, 2019

✔️ ci:test:relevant - 18 out of 18 jobs passed in 1 hour 1 minute 59 seconds 944 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 27800770b780195b90da7e420bd1ee6e67e3f095

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: b212f64b26aa6bcb20ddbc7004ed997acbfafe26

18 out of 18 jobs PASSED
18 Successful Jobs:
For more details click here.
@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Aug 14, 2019

Merged. Thank you.
View total diff: 890b15f...62fa1e8

@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Aug 14, 2019

@nhpatt is this acceptable:

        Status:
            properties:
                status:
                    type: string
            type: object

Where the model and one of the fields is the same thing? Do we do this else where?

I merged this @dgarciasarai but can you double check with @nhpatt?

@dgarciasarai

This comment has been minimized.

Copy link
Author

dgarciasarai commented Aug 14, 2019

Yes, we can double check that :)
Thanks @brianchandotcom

@nhpatt

This comment has been minimized.

Copy link

nhpatt commented Aug 15, 2019

We have another similar use case, bulk-rest that has a Status object that only returns a property, actionInProgress. We could avoid the entity in the OpenAPI all together by defining it inline in the path, the generator would/should generate similar code as it is now, an entity with the name of the property.

@dgarciasarai dgarciasarai deleted the dgarciasarai:LPS-99625 branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.