Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-102948 SF #79479

Closed
wants to merge 28 commits into from
Closed

LPS-102948 SF #79479

wants to merge 28 commits into from

Conversation

@pavel-savinov
Copy link

pavel-savinov commented Oct 14, 2019

No description provided.

ruben-pulido and others added 28 commits Oct 9, 2019
…out templates of 1_2_1_columns_i with one portlet per column
…out templates of 1_2_1_columns_i with multiple portlets per column
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Oct 14, 2019

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@pavel-savinov

This comment has been minimized.

Copy link
Author

pavel-savinov commented Oct 14, 2019

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Oct 14, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 22 seconds 683 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ecefb46aae5fd55057de23a741e64cdb5ebc1357

Sender Branch:

Branch Name: pr-446
Branch GIT ID: 31cb3ea1b4a7d4ff10b9ed8a54c8d428202e7e39

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Oct 14, 2019

ci:test:relevant - 21 out of 23 jobs passed in 1 hour 17 minutes 28 seconds 607 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 04175acca3f0bf36d467832af399166cdd81602c

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8c2f1493536e8380342b0a7dc6d9298ae4c02442

21 out of 23 jobs PASSED
21 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 04175ac:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
    Job Results:

    890 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #304016
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Unable to validate fragment entry
        com.liferay.fragment.exception.FragmentEntryContentException: There is no widget available for alias nav.
        	at com.liferay.fragment.entry.processor.portlet.PortletFragmentEntryProcessor.validateFragmentEntryHTML(PortletFragmentEntryProcessor.java:263)
        	at com.liferay.fragment.internal.processor.FragmentEntryProcessorRegistryImpl.validateFragmentEntryHTML(FragmentEntryProcessorRegistryImpl.java:151)
        	at com.liferay.fragment.internal.contributor.FragmentCollectionContributorTrackerImpl._validateFragmentEntry(FragmentCollectionContributorTrackerImpl.java:229)
        	at com.liferay.fragment.internal.contributor.FragmentCollectionContributorTrackerImpl._getFragmentEntries(FragmentCollectionContributorTrackerImpl.java:193)
        	at com.liferay.fragment.internal.contributor.FragmentCollectionContributorTrackerImpl.access$000(FragmentCollectionContributorTrackerImpl.java:59)
        	at com.liferay.fragment.internal.contributor.FragmentCollectionContributorTrackerImpl$FragmentCollectionContributorTrackerServiceTrackerCustomizer.addingService(FragmentCollectionContributorTrackerImpl.java:274)
        	at com.liferay.fragment.internal.contributor.FragmentCollectionContributorTrackerImpl$FragmentCollectionContributorTrackerServiceTrackerCustomizer.addingService(FragmentCollectionContributorTrackerImpl.java:257)
        	at com.liferay.osgi.service.tracker.collections.internal.map.ServiceTrackerMapImpl$DefaultEmitter.emit(ServiceTrackerMapImpl.java...
@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Oct 14, 2019

Merged. Thank you.
View total diff: 4d71f90...64269bf

@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Oct 14, 2019

@pavel-savinov @ruben-pulido beautiful please backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.