Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-103822 Add unit test to cover issue's use case. #80169

Closed

Conversation

@natocesarrego
Copy link

natocesarrego commented Oct 29, 2019

No description provided.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Oct 29, 2019

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Oct 29, 2019

✔️ ci:test:ci:test:sf - 1 out of 1 jobs passed in 2 minutes 20 seconds 227 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 3dbe9b6e37855a5a52a72aec198f02a68a42a77e

Sender Branch:

Branch Name: LPS-103822
Branch GIT ID: 69be1755ef174f763e0d90460dae4af9394ed662

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.
@natocesarrego

This comment has been minimized.

Copy link
Author

natocesarrego commented Oct 29, 2019

Resent as requested in #79958. I was able to resolve the conflicts locally, but I'm not sure why GitHub is still reporting conflicts. Maybe, the reason is because your master branch is ahead of liferay-portal master branch.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Oct 29, 2019

ci:test:stable - 7 out of 9 jobs passed

ci:test:relevant - 25 out of 29 jobs passed in 1 hour 13 minutes 33 seconds 305 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 98a866642785b3f47022ebdaff66fe368042767e

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: ed97ba4633ca1f030519ac365e520b1d4ae3def5

ci:test:stable - 7 out of 9 jobs PASSED
7 Successful Jobs:
ci:test:relevant - 25 out of 29 jobs PASSED
25 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
    Job Results:

    1023 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #87986
      1. DDMFormInstanceRecordStagedModelDataHandlerTest.testCleanAssetCategoriesAndTags
        java.lang.AssertionError: Thread Thread[com.liferay.dynamic.data.mapping.test-executor-thread,5,main] caught concurrent failure: java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.app.builder.internal.model.listener.DDMStructureModelListener, message=Unable to delete app builder apps
        java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.app.builder.internal.model.listener.DDMStructureModelListener, message=Unable to delete app builder apps
        	at com.liferay.portal.test.rule.LogAssertionAppender.append(LogAssertionAppender.java:60)
        	at org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
        	at org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
        	at org.apache.log4j.Category.callAppenders(Category.java:206)
        	at org.apache.log4j.Category.forcedLog(Category.java:391)
        	at org.apache.log4j.Category.log(Category.java:856)
        	at com.liferay.portal.log.Log4jLogImpl.error(Log4jLogImpl.java:54)
        	at com.liferay.portal.kernel.log.LogWrapper.error(LogWrapper.java:69)
        	at com.liferay.app.builder.internal.model.listener.DDMStructureModelListener.onAfterRemove(DDMStructureModelListener.java:43)
        	at com.liferay.app.builder.internal.model.listener.DDMStructureModelListener.onAfterRemove(DDMStructureModelListener.java:31)
        	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.remove(BasePersistenceImpl.java:476)
        	at com.liferay.dynamic.data.mapping.service.impl.DDMStructureLocalServiceImpl.de...
  2. test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8
    Job Results:

    1 Test Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #87983
           [exec] * What went wrong:
           [exec] Execution failed for task ':apps:dynamic-data-mapping:dynamic-data-mapping-form-renderer:compileTestJava'.
           [exec] > Compilation failed; see the compiler error output for details.
           [exec] 
           [exec] * Try:
           [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
           [exec] 
           [exec] * Exception is:
           [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:dynamic-data-mapping:dynamic-data-mapping-form-renderer:compileTestJava'.
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:110)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)
           [exec] 	at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
           [exec] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
           [exec] 	at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)
           [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:59)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
           [exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)

Failures in common with acceptance upstream results at f1f98ee:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
    Job Results:

    1023 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #87986
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Unable to delete app builder apps
        java.lang.NullPointerException
        	at com.liferay.app.builder.internal.model.listener.DDMStructureModelListener.onAfterRemove(DDMStructureModelListener.java:40)
        	at com.liferay.app.builder.internal.model.listener.DDMStructureModelListener.onAfterRemove(DDMStructureModelListener.java:31)
        	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.remove(BasePersistenceImpl.java:476)
        	at com.liferay.dynamic.data.mapping.service.impl.DDMStructureLocalServiceImpl.deleteStructure(DDMStructureLocalServiceImpl.java:585)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.portal.kernel.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:64)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.portal.kernel.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:64)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:49)
        	at com.sun.proxy.$Proxy729.deleteStructure(Unknown Source)
        	at com.liferay.dynamic.data.mapping.web.internal.exp...
  2. test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #322942
           [exec] * What went wrong:
           [exec] Execution failed for task ':apps:dynamic-data-mapping:dynamic-data-mapping-service:buildService'.
           [exec] > Process 'command '/opt/java/jdk1.8.0_121-x64/bin/java'' finished with non-zero exit value 1
           [exec] 
           [exec] * Try:
           [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
           [exec] 
           [exec] * Exception is:
           [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:dynamic-data-mapping:dynamic-data-mapping-service:buildService'.
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:110)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)
           [exec] 	at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
           [exec] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
           [exec] 	at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)
           [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:59)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
           [exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)
@natocesarrego

This comment has been minimized.

Copy link
Author

natocesarrego commented Oct 29, 2019

Hi @brianchandotcom,

From what I could see, the CI reported failures aren't related to this fix. These same failures are being reported in other pulls like, #80171.

Best.

@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Oct 29, 2019

Merged. Thank you.
View total diff: fb5ba2b...e0f0e22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.