Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-104636 #80990

Closed
wants to merge 1 commit into from
Closed

LPS-104636 #80990

wants to merge 1 commit into from

Conversation

@victorg1991
Copy link

victorg1991 commented Nov 14, 2019

… is happening is that when doing caretRangeFromPoint instead of finding the text node and work correctly the event is blocked by the before pseudoelement resulting in the function returning the wrong range
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Nov 14, 2019

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@victorg1991 victorg1991 changed the title LPS-104636 Do not catch click event in the before pseudoelement. What is happening is that when doing caretRangeFromPoint instead of finding the text node and work correctly the event is blocked by the before pseudoelement resulting in the function returning the wrong range LPS-104636 Nov 14, 2019
@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Nov 14, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 47 seconds 723 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c17126cb1cb99c8ad3eb1fe211ee9a1937c2f9db

Sender Branch:

Branch Name: LPS-104636
Branch GIT ID: f77eab135946075127e63c172c3b478d68313223

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.
@brianchandotcom

This comment has been minimized.

Copy link
Owner

brianchandotcom commented Nov 14, 2019

Merged. Thank you.
View total diff: eb84542...305e590

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Nov 14, 2019

✔️ ci:test:stable - 8 out of 8 jobs passed

✔️ ci:test:relevant - 25 out of 25 jobs passed in 1 hour 56 minutes 25 seconds 465 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b394cac9522a328317233ceed65e92790d72368a

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 641b541c33056f38e78e452f784325af601e9798

ci:test:stable - 8 out of 8 jobs PASSED
8 Successful Jobs:
ci:test:relevant - 25 out of 25 jobs PASSED
25 Successful Jobs:
For more details click here.
@victorg1991 victorg1991 deleted the victorg1991:LPS-104636 branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.