Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-107294 This param is never set, so it's always false and the preference is not stored #83516

Closed
wants to merge 1 commit into from
Closed

LPS-107294 This param is never set, so it's always false and the preference is not stored #83516

wants to merge 1 commit into from

Conversation

ealonso
Copy link

@ealonso ealonso commented Jan 20, 2020

No description provided.

@ealonso ealonso mentioned this pull request Jan 20, 2020
Closed
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 42 seconds 31 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0a081015ff90deebcac69f5a4085fe5f238c8d98

Sender Branch:

Branch Name: pr-2705
Branch GIT ID: 683e0b6ca545a92c579af447aea672d8ec1021e7

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 22 out of 24 jobs passed in 1 hour 14 minutes 45 seconds 477 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fd8ffae97e66755c1ab4f09f0e54ae4b3a6046dc

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: b48e22ed1129b772ad8bdbb965fb3eccc584f484

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 22 out of 24 jobs PASSED
22 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at fd8ffae:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8
    Job Results:

    210 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #373435
      1. ProjectTemplateFilesTest.testProjectTemplateFiles
        org.junit.ComparisonFailure: Forbidden leading or trailing whitespaces in ../project-templates-npm-angular-portlet/src/main/resources/archetype-resources/.babelrc.js expected:<module.exports = {};[]> but was:<module.exports = {};[
]>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at com.liferay.project.templates.ProjectTemplateFilesTest._testTextFile(ProjectTemplateFilesTest.java:926)
	at com.liferay.project.templates.ProjectTemplateFilesTest._testTextFile(ProjectTemplateFilesTest.java:951)
	at com.liferay.project.templates.ProjectTemplateFilesTest.access$400(ProjectTemplateFilesTest.java:70)
	at com.liferay.project.templates.ProjectTemplateFilesTest$1.visitFile(ProjectTemplateFilesTest.java:895)
	at com.liferay.project.templates.ProjectTemplateFilesTest$1.visitFile(ProjectTemplateFilesTest.java:840)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.project.templates.ProjectTemplateFilesTest._testProjectTemplateFiles(ProjectTemplateFilesTest.java:838)
	at com.liferay.project.templates.ProjectTemplateFilesTest.testProjectTemplateFiles(ProjectTemplateFilesTest.java:84)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1...

@robertoDiaz
Copy link

👍

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 6ef47c0...6b12c51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
4 participants
@ealonso @liferay-continuous-integration @robertoDiaz @brianchandotcom