Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-106717 - Sidebar with createPortal #84132

Closed
wants to merge 2 commits into from
Closed

LPS-106717 - Sidebar with createPortal #84132

wants to merge 2 commits into from

Conversation

sandrodw3
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@sandrodw3
Copy link
Author

/cc @ealonso

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 46 seconds 81 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 3515cd41b1e5f236327ad701b9198c99ce56a07e

Sender Branch:

Branch Name: pr-513
Branch GIT ID: 7818ec455b7d769774737146a289b5172f7d6d46

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 21 out of 26 jobs passed in 1 hour 33 minutes 58 seconds 121 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d798248382e301a7d07c5af3da9d24e0e9d32e71

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 7bd45299302c59ac1a75cf4d912ec0ec86f3701f

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 26 jobs PASSED
21 Successful Jobs:
For more details click here.

Failures unique to this pull:

Failures in common with acceptance upstream results at 1d0f67c:
  2. test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #366275

      Please fix semantic versioning on sandrodw3/pr-513

           [exec] 	+   version    1.1.0
     [exec] 	-   version    2.0.0
     [exec] * com.liferay.layout.util.template                   MINOR      1.2.0      2.0.0      2.1.0      VERSION INCREASE REQUIRED
     [exec] 	<   class      com.liferay.layout.util.template.LayoutColumn
     [exec] 		+   method     addAllPortlets()
     [exec] 			+   return     void
     [exec] 	+   class      com.liferay.layout.util.template.LayoutConversionResult
     [exec] 		+   method     clone()
     [exec] 			+   access     protected
     [exec] 			+   return     java.lang.Object
     [exec] 		+   method     equals(java.lang.Object)
     [exec] 			+   return     boolean
     [exec] 		+   method     finalize()
     [exec] 			+   access     protected
     [exec] 			+   return     void
     [exec] 		+   method     getConversionWarningMessages()
     [exec] 			+   return     java.lang.String[]
     [exec] 		+   method     getDraftLayout()
     [exec] 			+   return     com.liferay.portal.kernel.model.Layout
     [exec] 		+   method     getLayoutData()
     [exec] 			+   return     com.liferay.layout.util.template.LayoutData
     [exec] 		+   method     hashCode()
     [exec] 			+   return     int
     [exec] 		+   method     of(com.liferay.layout.util.template.LayoutData,java.lang.String[])
     [exec] 			+   access     static
     [exec] 			+   return     com.liferay.layout.util.template.LayoutConversionResult
     [exec] 		+   method     of(com.liferay.layout.util.template.LayoutData,java.lang.String[],com.liferay.portal.kernel.model.Layout)
     [exec] 			+   access     static
     [exec] 			+   return     com.liferay.layout.util.template.LayoutConversionResult
     [exec] 		+   method     toString()
     [exec] 			+   return     java.lang.String
     [exec] 	<   interface  com.liferay.layout.util.template.LayoutConverter
     [exec] 		+   method     convert(com.liferay.portal.kernel.model.Layout,java.util.Locale)
     [exec] 			+   return     com.liferay.layout.util.template.LayoutConversionResult
     [exec] 	+   version    1.2.0
     [exec] 	-   version    2.0.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.layout.api-6.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.layout.api/5.0.0/92a4772a28616f1dea69d70f1431b806edf6c4c3/com.liferay.layout.api-5.0.0.jar

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 383fed0...6b98ee2

@sandrodw3 sandrodw3 deleted the pr-513 branch March 10, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
4 participants
@sandrodw3 @liferay-continuous-integration @brianchandotcom @veroglez