Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-108911 Swap portal tools only when needed #84889

Closed
wants to merge 3 commits into from
Closed

LPS-108911 Swap portal tools only when needed #84889

wants to merge 3 commits into from

Conversation

petershin
Copy link

@petershin petershin commented Feb 18, 2020 •
edited

Hi Brian, this fix swaps the portal tool dependencies only when neeeded (i.e. running buildService or buildREST). In my local tests it reduced the ant all time by less than a minute.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 59 seconds 595 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f8164c39b231bb9f4771ef9cc426da801da07e50

Sender Branch:

Branch Name: m-021804
Branch GIT ID: ee6ac3be4020bdfe55b8054e8c790346190024c2

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@brianchandotcom
Copy link
Owner

@petershin nice!

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: f0e3994...2f25ac1

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 16 out of 19 jobs passed in 1 hour 36 minutes 8 seconds 858 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6622a92d19e7414ae9a9e1e02944b21885c5e890

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 7318e842aa146390e27f91f4087cb45f7c80ca8f

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 16 out of 19 jobs PASSED
16 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #362259
           [exec] * What went wrong:
     [exec] Execution failed for task ':dxp:apps:portal-search-tuning:portal-search-tuning-rankings-web:packageRunTest'.
     [exec] > java.io.IOException: Process '[/opt/dev/projects/github/liferay-portal/build/node/bin/node, /opt/dev/projects/github/liferay-portal/modules/yarn-1.13.0.js, --production, false, --registry, http://mirrors.lax.liferay.com:4873, run, test]' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':dxp:apps:portal-search-tuning:portal-search-tuning-rankings-web:packageRunTest'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$3.accept(ExecuteActionsTaskExecuter.java:166)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$3.accept(ExecuteActionsTaskExecuter.java:163)
     [exec] 	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:191)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:156)
     [exec] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:62)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:108)
     [exec] 	at org.gradle.api.internal.tasks.execution.ResolveBeforeExecutionOutputsTaskExecuter.execute(ResolveBeforeExecutionOutputsTaskExecuter.java:67)
     [exec] 	at org.gradle.api.internal.tasks.execution.ResolveAfterPreviousExecutionStateTaskExecuter.execute(ResolveAfterPreviousExecutionStateTaskExecuter.java:46)
     [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:94)
     [exec] 	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
     [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:95)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
  2. test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #115266
           [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:5144: 7 PMD violation(s) were found.
     [echo] 
     [echo] PMD VIOLATION: /opt/dev/projects/github/liferay-portal/modules/apps/layout/layout-api/src/main/java/com/liferay/layout/util/structure/ColumnLayoutStructureItem.java:33 > Ensure you override both equals() and hashCode() (PMD Rule: OverrideBothEqualsAndHashcode)
     [echo] For more information, please see https://pmd.github.io/pmd-6.8.0/pmd_rules_java_errorprone.html#overridebothequalsandhashcode.
     [echo] 
     [echo] PMD VIOLATION: /opt/dev/projects/github/liferay-portal/modules/apps/layout/layout-api/src/main/java/com/liferay/layout/util/structure/ContainerLayoutStructureItem.java:36 > Ensure you override both equals() and hashCode() (PMD Rule: OverrideBothEqualsAndHashcode)
     [echo] For more information, please see https://pmd.github.io/pmd-6.8.0/pmd_rules_java_errorprone.html#overridebothequalsandhashcode.
     [echo] 
     [echo] PMD VIOLATION: /opt/dev/projects/github/liferay-portal/modules/apps/layout/layout-api/src/main/java/com/liferay/layout/util/structure/DropZoneLayoutStructureItem.java:38 > Ensure you override both equals() and hashCode() (PMD Rule: OverrideBothEqualsAndHashcode)
     [echo] For more information, please see https://pmd.github.io/pmd-6.8.0/pmd_rules_java_errorprone.html#overridebothequalsandhashcode.
     [echo] 
     [echo] PMD VIOLATION: /opt/dev/projects/github/liferay-portal/modules/apps/layout/layout-api/src/main/java/com/liferay/layout/util/structure/FragmentLayoutStructureItem.java:33 > Ensure you override both equals() and hashCode() (PMD Rule: OverrideBothEqualsAndHashcode)
     [echo] For more information, please see https://pmd.github.io/pmd-6.8.0/pmd_rules_java_errorprone.html#overridebothequalsandhashcode.
     [echo] 
     [echo] PMD VIOLATION: /opt/dev/projects/github/liferay-portal/modules/apps/layout/layout-api/src/main/java/com/liferay/layout/util/structure/LayoutStructure.java:236 > Ensure you override both equals() and hashCode() (PMD Rule: OverrideBothEqualsAndHashcode)
     [echo] For more information, please see https://pmd.github.io/pmd-6.8.0/pmd_rules_java_errorprone.html#overridebothequalsandhashcode.
     [echo]

For upstream results, click here.

@petershin petershin deleted the m-021804 branch February 25, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
3 participants
@petershin @liferay-continuous-integration @brianchandotcom