Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-102573 Inline actions #85801

Closed

Conversation

javierdearcos
Copy link

No description provided.

Javier de Arcos and others added 10 commits March 5, 2020 08:28
The pattern of an action name is "get + parent scope + resource + list actions or item actions", depending on the type of actions.
This pattern is also consistent with the name of the methods of the actions included inside and with the method calling the actions method
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 57 seconds 931 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a46320f2bef254c981e289468bf331c446a89173

Sender Branch:

Branch Name: LPS-102573_inline
Branch GIT ID: eb9ed0406f8a8cab40751474aeacba53d9ba1a06

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 20 out of 22 jobs passed in 1 hour 47 minutes 48 seconds 622 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a70a80655148ff04e8f939bbdc1fa7b46e74e102

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 3838dac2ae9689eceb6374dee03b44cf836abfdb

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 20 out of 22 jobs PASSED
20 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #361936
           [exec] * What went wrong:
           [exec] Execution failed for task ':apps:ratings:ratings-taglib:packageRunTest'.
           [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
           [exec] 
           [exec] * Try:
           [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
           [exec] 
           [exec] * Exception is:
           [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:ratings:ratings-taglib:packageRunTest'.
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$3.accept(ExecuteActionsTaskExecuter.java:166)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$3.accept(ExecuteActionsTaskExecuter.java:163)
           [exec] 	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:191)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:156)
           [exec] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:62)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:108)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveBeforeExecutionOutputsTaskExecuter.execute(ResolveBeforeExecutionOutputsTaskExecuter.java:67)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveAfterPreviousExecutionStateTaskExecuter.execute(ResolveAfterPreviousExecutionStateTaskExecuter.java:46)
           [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:94)
           [exec] 	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:95)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
           [exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)

For upstream results, click here.

@brianchandotcom
Copy link
Owner

Merged. Thank you.

@brianchandotcom
Copy link
Owner

@javierdearcos see my changes in upstream. I'd like you to send me 2 follow up pulls:

1.) Can you remove

headless-common-spi/src/main/java/com/liferay/headless/common/spi/resource/SPICommentResource.java

I don't mind if there is a breaking change. It's only used internally for

headless-delivery/headless-delivery-impl/src/main/java/com/liferay/headless/delivery/internal/resource/v1_0/CommentResourceImpl.java

Anything that uses it, move it into headless-delivery-impl directly.

2.) Type:

git grep "private Page<" *ResourceImpl.java

Can you sort all those method parameters alphabetically? I just wanted it all sorted to match SearchUttil.java

When you send it, can you notify @hhuijser with that commit and on that pull. I want him to then auto SF enforce that change you're doing. In fact, there are probably 10-12 methods like that. Purposefully do all but 1 or 2. I want to test Hugo's script to make sure it catches the rest.

See my origin for my other changes. Thank you!

@brianchandotcom
Copy link
Owner

@javierdearcos please backport as you see fit.

@javierdearcos
Copy link
Author

Ok. Sorry, today I was all day fighting with some bugs. Tomorrow I make the two tasks you mentioned.

Thank you

@javierdearcos javierdearcos deleted the LPS-102573_inline branch March 10, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants