New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-102573 Inline actions #85801
LPS-102573 Inline actions #85801
Conversation
The pattern of an action name is "get + parent scope + resource + list actions or item actions", depending on the type of actions. This pattern is also consistent with the name of the methods of the actions included inside and with the method calling the actions method
CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests. Comment "ci:test" to run the full PR Tester for this pull. |
✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 57 seconds 931 msClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-102573_inline 1 Successful Jobs:For more details click here. |
✔️ ci:test:stable - 11 out of 11 jobs passed❌ ci:test:relevant - 20 out of 22 jobs passed in 1 hour 47 minutes 48 seconds 622 msClick here for more details.Base Branch:Branch Name: master Copied in Private Modules Branch:Branch Name: master-private ci:test:stable - 11 out of 11 jobs PASSED11 Successful Jobs:
ci:test:relevant - 20 out of 22 jobs PASSED2 Failed Jobs:20 Successful Jobs:
For more details click here.Failures unique to this pull:
For upstream results, click here. |
Merged. Thank you. |
@javierdearcos see my changes in upstream. I'd like you to send me 2 follow up pulls: 1.) Can you remove headless-common-spi/src/main/java/com/liferay/headless/common/spi/resource/SPICommentResource.java I don't mind if there is a breaking change. It's only used internally for headless-delivery/headless-delivery-impl/src/main/java/com/liferay/headless/delivery/internal/resource/v1_0/CommentResourceImpl.java Anything that uses it, move it into headless-delivery-impl directly. 2.) Type: git grep "private Page<" *ResourceImpl.java Can you sort all those method parameters alphabetically? I just wanted it all sorted to match SearchUttil.java When you send it, can you notify @hhuijser with that commit and on that pull. I want him to then auto SF enforce that change you're doing. In fact, there are probably 10-12 methods like that. Purposefully do all but 1 or 2. I want to test Hugo's script to make sure it catches the rest. See my origin for my other changes. Thank you! |
@javierdearcos please backport as you see fit. |
Ok. Sorry, today I was all day fighting with some bugs. Tomorrow I make the two tasks you mentioned. Thank you |
No description provided.