forked from liferay/liferay-portal
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-122562 Extract portlet preferences XML into separate preference table #96045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ener is still called.
…nstead of focusing on performance - there's too many usages to really dig into the best way to do each one and we can go back and tune them as needed.
…ue. We can now filter on name = 'portletSetupCss' but go back to one by one processing to keep the SQL simple. Unless there's many portletSetupCss values this should be faster.
…pgrades to portal and rename since they must run before the new upgrade. Also move over the announcements portletId upgrade so that it's always run before the preferences one. These should have all been run upgrading to 7.1.x. See LPS-55278, LPS-60361 and LPS-84128.
…t upgrade to portal.
…e upgrade and remove preferences field usage.
…out preferences column.
… preferences column.
…t be run again since we've dropped the preferences column.
…base upgrade is only used from modules.
Closing pull request because all |
ci:reopen |
Verified by QA, see Preston-Crary#1255 (comment) |
Fixed rebase failure, please see #96198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.