LPS-127308 [TS] [Bug: 7.3.x, master] LPS-127308 Category Filters are removed when doing a text search in Content Dashboard #99019

liferay-continuous-integration · 2021-02-22T12:05:48Z

Forwarded from: liferay-frontend#773 (Took 1 ci:forward attempt in 1 minute)

Original pull request comment:
Motivation

TS has found the next bug:

Steps to Reproduce

Create a Vocabulary and a category in it
Create 2 web contents: one with the category titled "test 1", one without a category titled "test 2"
Go to the App Menu > Content Dashboard
Select the category in the category filter
Search for the keyword "test"
Search result is shown without category filter

The original cause was that the Content Dashboard was not filling the assetCategoryId to the Search URL (done in this commit ), but even with this change, @balazssk has found that only one value per assetCategoryId was set.

That is the reason he has needed to make this commit in the ManagementToolbarTag, so we can handle multiple values for the same parameter name.

If you have any doubt, please, let me know.

Thanks!!

/cc @balazssk

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 23 jobs passed in 1 hour 36 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: aa80a9ec2a3bc90349b41faec6f2fa93e99fc0c4

Upstream Comparison:

Branch GIT ID: aa80a9ec2a3bc90349b41faec6f2fa93e99fc0c4
Jenkins Build URL: Acceptance Upstream DXP (master) #1567

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 21 out of 23 jobs PASSED

2 Failed Jobs:

21 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at aa80a9e:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #322964

Please fix semantic versioning on cgoncas/pr-855

     [exec] 		+   method     setHtmlTop(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     setId(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     setPageContext(javax.servlet.jsp.PageContext)
     [exec] 			+   return     void
     [exec] 		+   method     setShowButtons(boolean)
     [exec] 			+   return     void
     [exec] 		+   method     toString()
     [exec] 			+   return     java.lang.String
     [exec] 	<   class      com.liferay.frontend.taglib.servlet.taglib.SidebarPanelTag
     [exec] 		+   method     getCloseButton()
     [exec] 			+   return     boolean
     [exec] 		+   method     setCloseButton(boolean)
     [exec] 			+   return     void
     [exec] 	+   version    2.5.0
     [exec] 	-   version    2.6.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] 
     [exec] > Task :apps:frontend-taglib:frontend-taglib:syncVersions
     [exec] 
     [exec] > Task :apps:content-dashboard:content-dashboard-web:generateJSPJava
     [exec] Compiling JSP files of project ':apps:content-dashboard:content-dashboard-web' with /opt/dev/projects/github/liferay-portal/bundles/tomcat-9.0.40/webapps/ROOT/WEB-INF/lib/util-taglib.jar as dependency in place of 'com.liferay.portal:com.liferay.util.taglib'
     [exec] Note: Some input files use or override a deprecated API.
     [exec] Note: Recompile with -Xlint:deprecation for details.
     [exec] Note: Some input files use unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] 
     [exec] > Task :apps:content-dashboard:content-dashboard-web:compileJSP
     [exec] 
     [exec] 
     [exec] FAILURE: Build completed with 3 failures.
     [exec] 
     [exec] 1: Task failed with an exception.
     [exec] -----------
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:frontend-taglib:frontend-taglib-react:baseline'.
     [exec] > A failure occurred while executing com.liferay.gradle.plugins.baseline.internal.work.BaselineWorkAction
     [exec]    > org.gradle.api.GradleException: Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.frontend.taglib.react-5.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.frontend.taglib.react/4.1.2/ec050fd1c3aa0f51ab209177255ba6f126eabeef/com.liferay.frontend.taglib.react-4.1.2.jar

✔️ ci:test:sf - 1 out of 1 jobs passed in 25 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: aa80a9ec2a3bc90349b41faec6f2fa93e99fc0c4

Sender Branch:

Branch Name: pr-855
Branch GIT ID: e0119903156745bdd3c6994234c1d5c73606f0b4

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

…nt-dashboard-web The clay management toolbar component has been migrated to the new version using React components. All features previously handled by the management toolbar should still work as expected

liferay-continuous-integration · 2021-02-22T12:05:51Z

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

brianchandotcom · 2021-02-22T12:42:13Z

Merged. Thank you.
View total diff: 6f016af...dc2af94

balazssk and others added 8 commits February 22, 2021 11:17

LPS-127308 Add assetCategoryId parameters to searchActionURL

db1574b

LPS-127308 Handle multiple parameters with the same name

1ce1eca

LPS-127308 Simplify

c7408f6

LPS-127308 Add same logic for assetTagId and authorIds.

62264eb

LPS-127308 Handle multiple parameters with the same name in clay as well

57d9437

LPS-121871 Add new onFilterDropdownItemClick callback

a1b599c

LPS-127308 Migrate usages of <clay:management-toolbar-v2/> in conte…

34b57fc

…nt-dashboard-web The clay management toolbar component has been migrated to the new version using React components. All features previously handled by the management toolbar should still work as expected

LPS-127308 Add missing selectAuthor function

e011990

liferay-continuous-integration mentioned this pull request Feb 22, 2021

LPS-127308 [TS] [Bug: 7.3.x, master] LPS-127308 Category Filters are removed when doing a text search in Content Dashboard liferay-frontend/liferay-portal#773

Closed

liferay-continuous-integration added ci:test:relevant - success ci:test:sf - success ci:test:stable - success labels Feb 22, 2021

brianchandotcom closed this Feb 22, 2021

liferay-continuous-integration deleted the ci-forward-pr-855-pr-773-sender-cgoncas-ts-1613995533584 branch February 27, 2021 11:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-127308 [TS] [Bug: 7.3.x, master] LPS-127308 Category Filters are removed when doing a text search in Content Dashboard #99019

LPS-127308 [TS] [Bug: 7.3.x, master] LPS-127308 Category Filters are removed when doing a text search in Content Dashboard #99019

liferay-continuous-integration commented Feb 22, 2021

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

liferay-continuous-integration commented Feb 22, 2021

brianchandotcom commented Feb 22, 2021

Navigation Menu

LPS-127308 [TS] [Bug: 7.3.x, master] LPS-127308 Category Filters are removed when doing a text search in Content Dashboard #99019

LPS-127308 [TS] [Bug: 7.3.x, master] LPS-127308 Category Filters are removed when doing a text search in Content Dashboard #99019

Conversation

liferay-continuous-integration commented Feb 22, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 23 jobs passed in 1 hour 36 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

✔️ ci:test:sf - 1 out of 1 jobs passed in 25 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 22, 2021

brianchandotcom commented Feb 22, 2021