Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Don't hide if the tooltip isn't ready. #16

Merged
merged 1 commit into from

2 participants

Lachie Cox Brian Cray
Lachie Cox

I found that hide was being called-back before show (and thus readify()). This protects against that case.

I think its best simply to bail in this case, rather than call readify() and continue.

Lachie Cox lachie Don't hide if the tooltip isn't ready.
I found that hide was being called-back before
show (and thus readify()). This protects against
this case.
f7d9c7f
Brian Cray briancray merged commit 9e87162 into from
Brian Cray
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 16, 2011
  1. Lachie Cox

    Don't hide if the tooltip isn't ready.

    lachie authored
    I found that hide was being called-back before
    show (and thus readify()). This protects against
    this case.
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 0 deletions.
  1. +4 −0 tooltipsy.source.js
4 tooltipsy.source.js
View
@@ -126,6 +126,10 @@
$.tooltipsy.prototype.hide = function (e) {
var base = this;
+ if (base.ready === false) {
+ return;
+ }
+
if (e && e.relatedTarget === base.$tip[0]) {
base.$tip.bind('mouseleave', function (e) {
if (e.relatedTarget === base.$el[0]) {
Something went wrong with that request. Please try again.