New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New approach to tests #2

Merged
merged 3 commits into from Jul 25, 2017

Conversation

Projects
None yet
3 participants
@lancew
Contributor

lancew commented Jul 23, 2017

Hi, this pull request introduces the idea of testing via Net::SSH::Any::Test which may or may not be a good idea, I'd be interested to know what you think.

The tests I have added actually do very little.
I intend on seeing if I can find a way to test socks also, that is next. But if the approach is not one that makes sense I can hold off doing that.

Lance

lancew added some commits Jul 21, 2017

Add new test using Net::SSH::Any::Test
Use Net::SSH::Any::Test so that we can spin up a SSH server to talk to.

Possibly not the way to approach this problem.

These tests do not test the module beyond confirming that it will
correctly use Net::SSH::Perl if no socks server params provided.
Require perl 5.10
Math-GMP-2.15 is a dependency and requires Perl 5.10.
So as potentially short-term work around require 5.10 in the module
and also stop testing on v5.8
Bump Devel::Cover from 1.23 to 1.25
Hoping this resolves the failure on TravisCI (Perl v 5.26)
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 23, 2017

Coverage Status

Coverage increased (+2.8%) to 25.0% when pulling ef5f04c on lancew:master into c9a26ba on briandfoy:master.

coveralls commented Jul 23, 2017

Coverage Status

Coverage increased (+2.8%) to 25.0% when pulling ef5f04c on lancew:master into c9a26ba on briandfoy:master.

@briandfoy briandfoy merged commit 7ac88ea into briandfoy:master Jul 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@briandfoy

This comment has been minimized.

Show comment
Hide comment
@briandfoy

briandfoy Jul 25, 2017

Owner

Thanks! For some reason I'm not getting all of my GitHub notifications so if you send another PR and don't get a response, let me know.

Owner

briandfoy commented Jul 25, 2017

Thanks! For some reason I'm not getting all of my GitHub notifications so if you send another PR and don't get a response, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment