Skip to content

Fix a format string bug in "cat -n". #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2019
Merged

Fix a format string bug in "cat -n". #64

merged 1 commit into from
May 31, 2019

Conversation

@shlomif
Copy link
Contributor

@shlomif shlomif commented Dec 21, 2018

See https://en.wikipedia.org/wiki/Uncontrolled_format_string . The
output was wrong if given %d / etc. as well.

@coveralls
Copy link

coveralls commented Dec 21, 2018

Pull Request Test Coverage Report for Build 42

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.549%
Totals Coverage Status
Change from base Build 39: 0.0%
Covered Lines: 65
Relevant Lines: 71
💛 - Coveralls

8 similar comments
@coveralls
Copy link

coveralls commented Dec 21, 2018

Pull Request Test Coverage Report for Build 42

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.549%
Totals Coverage Status
Change from base Build 39: 0.0%
Covered Lines: 65
Relevant Lines: 71
💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 21, 2018

Pull Request Test Coverage Report for Build 42

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.549%
Totals Coverage Status
Change from base Build 39: 0.0%
Covered Lines: 65
Relevant Lines: 71
💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 21, 2018

Pull Request Test Coverage Report for Build 42

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.549%
Totals Coverage Status
Change from base Build 39: 0.0%
Covered Lines: 65
Relevant Lines: 71
💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 21, 2018

Pull Request Test Coverage Report for Build 42

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.549%
Totals Coverage Status
Change from base Build 39: 0.0%
Covered Lines: 65
Relevant Lines: 71
💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 21, 2018

Pull Request Test Coverage Report for Build 42

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.549%
Totals Coverage Status
Change from base Build 39: 0.0%
Covered Lines: 65
Relevant Lines: 71
💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 21, 2018

Pull Request Test Coverage Report for Build 42

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.549%
Totals Coverage Status
Change from base Build 39: 0.0%
Covered Lines: 65
Relevant Lines: 71
💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 21, 2018

Pull Request Test Coverage Report for Build 42

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.549%
Totals Coverage Status
Change from base Build 39: 0.0%
Covered Lines: 65
Relevant Lines: 71
💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 21, 2018

Pull Request Test Coverage Report for Build 42

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.549%
Totals Coverage Status
Change from base Build 39: 0.0%
Covered Lines: 65
Relevant Lines: 71
💛 - Coveralls

@shlomif
Copy link
Contributor Author

shlomif commented Jan 16, 2019

Hi! Any news?

@shlomif
Copy link
Contributor Author

shlomif commented Apr 16, 2019

Hi! Do you need anything or can this be merged?

@briandfoy briandfoy merged commit 67fe962 into briandfoy:master May 31, 2019
@shlomif
Copy link
Contributor Author

shlomif commented May 31, 2019

Thanks!

@briandfoy briandfoy added Program: cat The cat program Type: bug an existing feature does not work labels Jul 11, 2023
@briandfoy briandfoy self-assigned this Jul 11, 2023
@briandfoy briandfoy added the Status: released there is a new release with this fix label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@briandfoy briandfoy

Labels

Program: cat The cat program Status: released there is a new release with this fix Type: bug an existing feature does not work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shlomif @coveralls @briandfoy