New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace :utf8 with :encoding(UTF-8) for strict I/O validation #16

Merged
merged 2 commits into from Nov 13, 2017

Conversation

Projects
None yet
3 participants
@paultcochrane
Contributor

paultcochrane commented Oct 8, 2017

Perlcritic mentions that using :encoding(UTF-8) is better practice than simply using :utf8 in I/O operations. This PR fixes the issue and hence removes the perlcritic warning.

This PR is submitted in the hope that it is useful. If you have any questions or comments about it, please don't hesitate to let me know, and if you wish for anything to be changed I'll update the PR as appropriate and resubmit.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 8, 2017

Coverage Status

Coverage remained the same at 66.94% when pulling 017832c on paultcochrane:pr/use-encoding-utf8 into 67cf94a on briandfoy:master.

coveralls commented Oct 8, 2017

Coverage Status

Coverage remained the same at 66.94% when pulling 017832c on paultcochrane:pr/use-encoding-utf8 into 67cf94a on briandfoy:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 30, 2017

Coverage Status

Coverage remained the same at 70.697% when pulling ae4010f on paultcochrane:pr/use-encoding-utf8 into d91e87d on briandfoy:master.

coveralls commented Oct 30, 2017

Coverage Status

Coverage remained the same at 70.697% when pulling ae4010f on paultcochrane:pr/use-encoding-utf8 into d91e87d on briandfoy:master.

@briandfoy briandfoy merged commit 6d7e531 into briandfoy:master Nov 13, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment