New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable #17

Merged
merged 1 commit into from Oct 29, 2017

Conversation

Projects
None yet
3 participants
@paultcochrane
Contributor

paultcochrane commented Oct 8, 2017

Perlcritic had actually noticed that a variable was being assigned to within a conditional statement, however looking at the code I noticed that the $error variable was never being used, hence this PR. If you actually intended for this line of code to perform some purpose other than that done by the ok() and diag() calls later in the code then I'd be really interested in the reason why the code with the $error variable was included; I wouldn't expect you to add such code unless it was necessary for some reason, and I have the vague feeling I'm missing something subtle here.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 8, 2017

Coverage Status

Coverage remained the same at 66.94% when pulling 66f6e99 on paultcochrane:pr/remove-unused-variable into 67cf94a on briandfoy:master.

coveralls commented Oct 8, 2017

Coverage Status

Coverage remained the same at 66.94% when pulling 66f6e99 on paultcochrane:pr/remove-unused-variable into 67cf94a on briandfoy:master.

@briandfoy briandfoy merged commit 60bae0b into briandfoy:master Oct 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@paultcochrane paultcochrane deleted the paultcochrane:pr/remove-unused-variable branch Nov 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment