New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable '$got' in dist_version tests #24

Merged
merged 1 commit into from Oct 29, 2017

Conversation

Projects
None yet
3 participants
@paultcochrane
Contributor

paultcochrane commented Oct 15, 2017

While reading the test code I noticed that the dist_version method was
being called directly in the test check and hence the temporary variable
wasn't needed and hence can be removed.

Remove unused variable '$got' in dist_version tests
While reading the test code I noticed that the `dist_version` method was
being called directly in the test check and hence the temporary variable
wasn't needed and hence can be removed.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 15, 2017

Coverage Status

Coverage remained the same at 66.94% when pulling 48a32d2 on paultcochrane:pr/remove-unused-variable-in-tests into 6532dbf on briandfoy:master.

coveralls commented Oct 15, 2017

Coverage Status

Coverage remained the same at 66.94% when pulling 48a32d2 on paultcochrane:pr/remove-unused-variable-in-tests into 6532dbf on briandfoy:master.

@briandfoy briandfoy merged commit ca54ee8 into briandfoy:master Oct 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@paultcochrane paultcochrane deleted the paultcochrane:pr/remove-unused-variable-in-tests branch Nov 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment