New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that version numbers can be more than 2dp #25

Merged
merged 1 commit into from Oct 29, 2017

Conversation

Projects
None yet
3 participants
@paultcochrane
Contributor

paultcochrane commented Oct 15, 2017

These tests check for the issue mentioned in GH #5, namely that version
numbers such as 1.001 should not be reduced to 1.01.

Unfortunately, it seems that the issue mentioned in #5 isn't an issue anymore. Perhaps these changes are useful to document that, or perhaps I've missed something. Either way, here's the code, hope it helps in some way!

Check that version numbers can be more than 2dp
These tests check for the issue mentioned in GH #5, namely that version
numbers such as 1.001 should not be reduced to 1.01.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 15, 2017

Coverage Status

Coverage remained the same at 66.94% when pulling 2da9e5e on paultcochrane:pr/check-3dp-version-numbers into 6532dbf on briandfoy:master.

coveralls commented Oct 15, 2017

Coverage Status

Coverage remained the same at 66.94% when pulling 2da9e5e on paultcochrane:pr/check-3dp-version-numbers into 6532dbf on briandfoy:master.

@briandfoy briandfoy merged commit d91e87d into briandfoy:master Oct 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@paultcochrane paultcochrane deleted the paultcochrane:pr/check-3dp-version-numbers branch Nov 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment