New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return release date string via get_release_date() method #28

Merged
merged 1 commit into from Oct 29, 2017

Conversation

Projects
None yet
3 participants
@paultcochrane
Contributor

paultcochrane commented Oct 21, 2017

The release date given in the Changes file should conform to the
format defined in CPAN::Changes::Spec. Although the code in the
release script already conformed to this spec, it's nicer to have the
functionality wrapped in a method. These changes add the new
get_release_date() method as well as tests for it, and replace the
existing code in the release script with the new method call.

Return release date string via get_release_date() method
The release date given in the Changes file should conform to the
format defined in CPAN::Changes::Spec.  Although the code in the
`release` script already conformed to this spec, it's nicer to have the
functionality wrapped in a method.  These changes add the new
`get_release_date()` method as well as tests for it, and replace the
existing code in the `release` script with the new method call.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 21, 2017

Coverage Status

Coverage increased (+0.3%) to 67.21% when pulling ba076ed on paultcochrane:pr/add-get-release-date into 6532dbf on briandfoy:master.

coveralls commented Oct 21, 2017

Coverage Status

Coverage increased (+0.3%) to 67.21% when pulling ba076ed on paultcochrane:pr/add-get-release-date into 6532dbf on briandfoy:master.

@briandfoy briandfoy merged commit 929256f into briandfoy:master Oct 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@paultcochrane paultcochrane deleted the paultcochrane:pr/add-get-release-date branch Nov 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment